Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only][full-ci]added then steps for apiProvisioning-v2 suite #39836

Merged
merged 1 commit into from
Mar 3, 2022
Merged

[tests-only][full-ci]added then steps for apiProvisioning-v2 suite #39836

merged 1 commit into from
Mar 3, 2022

Conversation

sushmita56
Copy link
Contributor

Description

This PR adds Then steps to existing API test scenarios to better check the results of When steps.

Suite Covered

  • apiProvisioning-v2

Related Issues

How Has This Been Tested?

  • Locally
  • CI

Types of changes

  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@sushmita56 sushmita56 self-assigned this Feb 28, 2022
@phil-davis
Copy link
Contributor

@sushmita56 I just merged PR #39688 and that added some scenarios to editUser.feature

Please check the new scenarios - they also might need to have HTTP status checks etc added to them.

@sushmita56 sushmita56 mentioned this pull request Mar 1, 2022
Closed
@sushmita56 sushmita56 force-pushed the then-steps-in-apiProvisioning-v2 branch from fe2a382 to c872a4b Compare March 1, 2022 06:12
@sushmita56 sushmita56 force-pushed the then-steps-in-apiProvisioning-v2 branch from 79caeee to ed59d9f Compare March 1, 2022 09:33
@sushmita56 sushmita56 marked this pull request as draft March 1, 2022 10:37
@sushmita56 sushmita56 marked this pull request as ready for review March 2, 2022 05:53
@sushmita56 sushmita56 force-pushed the then-steps-in-apiProvisioning-v2 branch from ed59d9f to cac7f02 Compare March 2, 2022 06:56
kiranparajuli589
kiranparajuli589 reviewed Mar 2, 2022
View reviewed changes
Copy link
Contributor

@kiranparajuli589 kiranparajuli589 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

kiranparajuli589
kiranparajuli589 reviewed Mar 3, 2022
View reviewed changes
tests/acceptance/features/apiProvisioning-v2/resetUserPassword.feature Outdated
Comment on lines 150 to 155
When the user "brand-new-user" requests these endpoints with "PROPFIND" to get property "d:getetag" using basic auth and generated app password about user "brand-new-user"
| endpoint |
| /remote.php/dav/files/%username%/textfile0.txt |
Then the HTTP status code of responses on all endpoints should be "207"
When user "brand-new-user" resets the password of user "brand-new-user" to "%alt1%" using the provisioning API
Then the content of file "textfile0.txt" for user "brand-new-user" using password "%alt1%" should be "ownCloud test text file 0" plus end-of-line
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why removing these steps?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The second When step has been changed into the Given step. The first When step is making a request before the brand-new-user resets his login password. And the test scenario for this case has been added in the apiProvisioningUsingAppPassword.feature file. Also here we're testing whether the app's password is preserved or not after resetting the login password. So in my opinion these steps can be excluded from this scenario.

@sushmita56 sushmita56 force-pushed the then-steps-in-apiProvisioning-v2 branch from cac7f02 to 6704f4f Compare March 3, 2022 09:25
@sonarcloud
Copy link

sonarcloud bot commented Mar 3, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

kiranparajuli589
kiranparajuli589 reviewed Mar 3, 2022
View reviewed changes
Copy link
Contributor

@kiranparajuli589 kiranparajuli589 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@sushmita56 sushmita56 merged commit 0603065 into master Mar 3, 2022
@delete-merged-branch delete-merged-branch bot deleted the then-steps-in-apiProvisioning-v2 branch March 3, 2022 10:52
@sushmita56 sushmita56 mentioned this pull request Mar 11, 2022
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kiranparajuli589 kiranparajuli589 kiranparajuli589 left review comments

@individual-it individual-it individual-it approved these changes

@saw-jan saw-jan Awaiting requested review from saw-jan

@phil-davis phil-davis Awaiting requested review from phil-davis

@grgprarup grgprarup Awaiting requested review from grgprarup

@SagarGi SagarGi Awaiting requested review from SagarGi

Assignees

@sushmita56 sushmita56

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sushmita56 @phil-davis @individual-it @kiranparajuli589