Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only] added a @notToImplementOnOcis tag in apiProvisioningV2 suite #39869

Merged
merged 2 commits into from
Mar 11, 2022

Conversation

sushmita56
Copy link
Contributor

Description

This PR adds

How Has This Been Tested?

  • Locally
  • CI

Types of changes

  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@update-docs
Copy link

update-docs bot commented Mar 11, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@sushmita56 sushmita56 self-assigned this Mar 11, 2022
@sushmita56 sushmita56 changed the title added a @notToImplementOnOcis tag in apiProvisioningV2 suite [tests-only] added a @notToImplementOnOcis tag in apiProvisioningV2 suite Mar 11, 2022
@@ -76,6 +76,7 @@ Feature: access user provisioning API using app password
Then the HTTP status code should be "401"
And the API should not return any data

@notToImplementOnOCIS
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are other scenarios in this file that do not have notToImplementOnOCIS tag.
I am surprised - I thought that all "app password" test scenarios should have notToImplementOnOCIS ???

Please investigate separately about the other scenarios. But we can merge this PR to get things moving.

@sonarcloud
Copy link

sonarcloud bot commented Mar 11, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@SwikritiT SwikritiT merged commit a293d13 into master Mar 11, 2022
@delete-merged-branch delete-merged-branch bot deleted the add-notToImplementOnOcis-tag branch March 11, 2022 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants