Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[full-ci][tests-only]Update test to match ocis behaviour #40009

Merged
merged 1 commit into from
Apr 25, 2022
Merged

[full-ci][tests-only]Update test to match ocis behaviour #40009

merged 1 commit into from
Apr 25, 2022

Conversation

SwikritiT
Copy link
Contributor

@SwikritiT SwikritiT commented Apr 25, 2022 •
edited
Loading

Description

owncloud/ocis#3564 added some tests to expected to fail while they shouldn't be there. This PR updates the tests so that they work according to current OCIS behavior.

Related Issue

Motivation and Context

How Has This Been Tested?

  • CI
  • locally

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

phil-davis
phil-davis approved these changes Apr 25, 2022
View reviewed changes
Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - that was the change in oCIS. Feel free to merge when you are happy with it.

@SwikritiT SwikritiT marked this pull request as ready for review April 25, 2022 10:18
@SwikritiT SwikritiT self-assigned this Apr 25, 2022
@sonarcloud
Copy link

sonarcloud bot commented Apr 25, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@phil-davis
Copy link
Contributor

@SwikritiT if this can be merged "real soon" then I can adjust the core commit id in my "bump" PRs like owncloud/ocis#3576 and the fixed tests will get used tonight in oCIS and reva.

@SwikritiT SwikritiT merged commit b262ada into master Apr 25, 2022
@delete-merged-branch delete-merged-branch bot deleted the update-tests branch April 25, 2022 11:12
@SwikritiT SwikritiT mentioned this pull request Apr 25, 2022
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phil-davis phil-davis phil-davis approved these changes

Assignees

@SwikritiT SwikritiT

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SwikritiT @phil-davis