Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only] [full-ci] Bump core commit id for tests #3576

Merged
merged 2 commits into from
Apr 25, 2022

Conversation

phil-davis
Copy link
Contributor

Description

Related Issue

owncloud/QA#738

How Has This Been Tested?

CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@phil-davis phil-davis self-assigned this Apr 25, 2022
@phil-davis phil-davis force-pushed the core-commit-id-202220425 branch 2 times, most recently from 5d62c81 to e1c77a5 Compare April 25, 2022 10:34
@phil-davis phil-davis marked this pull request as ready for review April 25, 2022 10:35
@@ -577,31 +577,6 @@ cannot share a folder with create permission

- [apiSharePublicLink2/uploadToPublicLinkShare.feature:198](https://github.com/owncloud/core/blob/master/tests/acceptance/features/apiSharePublicLink2/uploadToPublicLinkShare.feature#L198)

#### [Resharing does not work with ocis storage](https://github.com/owncloud/product/issues/265)

- [apiShareReshareToShares3/reShareWithExpiryDate.feature:403](https://github.com/owncloud/core/blob/master/tests/acceptance/features/apiShareReshareToShares3/reShareWithExpiryDate.feature#L403)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: these were duplicated further down the expected-failures. I removed the duplication.

@@ -577,31 +577,6 @@ cannot share a folder with create permission

- [apiSharePublicLink2/uploadToPublicLinkShare.feature:198](https://github.com/owncloud/core/blob/master/tests/acceptance/features/apiSharePublicLink2/uploadToPublicLinkShare.feature#L198)

#### [Resharing does not work with ocis storage](https://github.com/owncloud/product/issues/265)

- [apiShareReshareToShares3/reShareWithExpiryDate.feature:403](https://github.com/owncloud/core/blob/master/tests/acceptance/features/apiShareReshareToShares3/reShareWithExpiryDate.feature#L403)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: these were duplicated further down the expected-failures. I removed the duplication.

@SwikritiT
Copy link
Contributor

@phil-davis I've merged owncloud/core#40009 you can update the id

Copy link
Contributor

@kiranparajuli589 kiranparajuli589 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@phil-davis
Copy link
Contributor Author

phil-davis commented Apr 25, 2022

https://drone.owncloud.com/owncloud/ocis/10872/48/9

runsh: Total unexpected failed scenarios throughout the test run:
webUISharingPublicBasic/publicLinkCreate.feature:172
runsh: There were no unexpected success.

A web scenario failed - I will restart CI.

https://drone.owncloud.com/owncloud/ocis/10876/48/9
same fail happened again. I made test PR #3580 to look into it.

@sonarcloud
Copy link

sonarcloud bot commented Apr 25, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@phil-davis phil-davis merged commit 84c8115 into master Apr 25, 2022
@delete-merged-branch delete-merged-branch bot deleted the core-commit-id-202220425 branch April 25, 2022 16:06
ownclouders pushed a commit that referenced this pull request Apr 25, 2022
Merge: 634d557 29c7a5a
Author: Phil Davis <phil@jankaritech.com>
Date:   Mon Apr 25 21:51:06 2022 +0545

    Merge pull request #3576 from owncloud/core-commit-id-202220425

    [tests-only] [full-ci] Bump core commit id for tests
ownclouders pushed a commit that referenced this pull request Apr 26, 2022
Merge: 634d557 29c7a5a
Author: Phil Davis <phil@jankaritech.com>
Date:   Mon Apr 25 21:51:06 2022 +0545

    Merge pull request #3576 from owncloud/core-commit-id-202220425

    [tests-only] [full-ci] Bump core commit id for tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants