Prepare the repo to include external adoc files #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EParzefall
pushed a commit
that referenced
this pull request
Nov 2, 2021
EParzefall
pushed a commit
that referenced
this pull request
Nov 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR prepares the repo to include .adoc files from an URI.
For details see the comments in script: lib/extensions/remote-include-processor.js
Referencing owncloud/docs-client-ios-app#18 (Prepare the repo to include external adoc files)
That is the first repo where this is needed, harmonizing the setup.
Tests
Tests have been made in the referenced PR - all works as expected.
The nice thing having this, we can now include any .adoc file automatically generated by a script from an external URI like another github repo, without manually maintaining static content.
NOTE
Any external created content, especially if created dynamically, MUST be checked carefully for building properly!
Backport to 2.9 and 2.8