Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare the repo to include .adoc files from an URI #18

Merged
merged 1 commit into from
Nov 2, 2021

Conversation

mmattel
Copy link
Contributor

@mmattel mmattel commented Nov 1, 2021

This PR prepares the repo to include .adoc files from an URI.

For details see the comments in script: lib/extensions/remote-include-processor.js

Necessary for:

Tests
I have tested this by including an .adoc document from the docs repo via an URI and doing a build respectively running makepdf - all works as expected.

The nice thing having this, we can now include any .adoc file automatically generated by a script from an external URI like another github repo, without manually maintaining static content.

NOTE
Any external created content, especially if created dynamically, MUST be checked carefully for building properly!

Backport to 11.7

@michaelstingl fyi

Copy link
Contributor

@EParzefall EParzefall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EParzefall EParzefall merged commit 08825e5 into master Nov 2, 2021
@delete-merged-branch delete-merged-branch bot deleted the add_include_from_external branch November 2, 2021 07:54
EParzefall pushed a commit that referenced this pull request Nov 2, 2021
@michaelstingl
Copy link
Contributor

See owncloud/ios-app#1070 for future include source location.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants