[fix/single-accouont-display-name] Show Display Name in Branded Single Account View #1049

hosy · 2021-10-14T13:58:15Z

Description

Username could look like a UUID, which is not user friendly. Now showing the displayName, if available, other show the userName.

Related Issue

https://github.com/owncloud/enterprise/issues/4798

Motivation and Context

How Has This Been Tested?

brand app as oc.online
configure an account
check header for displayName

Screenshots (if appropriate):

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

My code follows the code style of this project.
My change requires a change to the documentation.
I have updated the documentation accordingly.
I have read the CONTRIBUTING document.
I have added tests to cover my changes.
All new and existing tests passed.
Added changelog files for the fixed issues in folder changelog/unreleased

…w showing the displayName and if not available, the userName

jesmrec · 2021-10-19T14:41:28Z

I get some compilation errors in this branch, using the commit 96ae32c5, in file StaticLoginSingleAccountServerListViewController.swift Line 166:

CC @hosy

hosy · 2021-10-20T08:00:23Z

@jesmrec problem is fixed. Please try again.

jesmrec · 2021-10-21T13:07:32Z

(1)

My test server returns:

curl -u user1:a http://mytest1:37000/ocs/v2.php/cloud/user\?format\=json

{
   "ocs":{
      "meta":{
         "status":"ok",
         "statuscode":200,
         "message":"OK",
         "totalitems":"",
         "itemsperpage":""
      },
      "data":{
         "id":"user1",
         "display-name":"Jesus Recio",
         "email":"a@a"
      }

but, it looks like:

showing the username instead the displayname.

using the oC online theme (is the dark color in text a branding issue?)

aa4373d9
iPadAir2 v14.7

hosy · 2021-11-08T14:55:33Z

@felix-schwarz it looks like, that the property display-name is only available, after a connection was initiated.
Is it possible to make this property available, without a connection?

ios-app/ownCloudAppFramework/SDK Extensions/OCBookmark+AppExtensions.m

Line 23 in e7abd1d

- (NSString *)displayName

felix-schwarz · 2021-11-09T13:38:41Z

@hosy Unfortunately that's not possible, since that info (typically the full name of a person) can only be retrieved from the server. It is set in BookmarkViewController.swift:569 from values returned from user.php during account setup.

hosy · 2021-11-09T13:40:28Z

@hosy Unfortunately that's not possible, since that info (typically the full name of a person) can only be retrieved from the server. It is set in BookmarkViewController.swift:569 from values returned from user.php during account setup.

Is it possible to add a workaround, loading user data, when this information is needed?

felix-schwarz · 2021-11-09T13:47:13Z

@hosy In that case, you can use the bookmark to create an OCConnection and then call - (NSProgress *)connectWithCompletionHandler:(void(^)(NSError *error, OCIssue *issue))completionHandler on that instance. Then, when the completionHandler is run and no error or issue was returned, you can grab the info from connection.loggedInUser.displayName.

…the table view

hosy · 2021-11-15T14:48:04Z

@jesmrec now I'm retrieving the users display name from server and reloading the view, after it was retrieved. It cannot be loaded, if the server is not available. Please have another look. Thanks!

jesmrec · 2021-11-16T16:23:51Z

Tested:

Static display name
Display name's changes

Everything correct on my side

Approved

* added additional build information to the Branding.plist file: - ios-app and ios-sdk commit hash - copy the Branding.plist with additional app and build information as file name * [feature/biometrical-mdm-setting ]Suggest Biometrical Unlock (#1046) * Suggest biometrical unlock, after setting up passcode * - do not show Cancel button, if password is enforced - update biometrical UI switch value in settings view - fixed bug, dismissing the view, if biometrical is not available * moved extension into ownCloudAppShared folder * Branding: (#1045) - add new `branding.user-defaults-default-values` class settings key to allow registration of alternative defaults for user defaults * - fix bug where a quick access entry showed no items when selected a second time. (#1044) * used better wording for "Cellular transfers" * - in branded clients: removed UISwitch to enable/disable deletion of available offline files in manage screen - fixed text center layout in table view cell * fixed UI issue in sharing view * #4801 "Log out" text changes * #4801 text changes for "Prevent gestures" * - ThemeTableViewCell, StaticTableViewRow: new .plain message style (#1053) - add new view controller to present license texts for each component individually * [feature/modular-localization] Modular localization (#1054) * - Branding class: - move logic for VendorServices.appName to Branding.appDisplayName - change app.name variable value to that of Branding.appDisplayName - switch String.localized from NSLocalizedString() to OCLocale.localize() - SwiftLint: adapt to latest SwiftLint version * - add .localized(replacements) function to provide easy access to custom variables support in OCLocale * - update SDK * [feature/mdm-auto-connect] Skip Account Screen via MDM (#1056) * #4801 Skip "Manage" screen / automatically open "Files" screen after login via MDM parameter account.auto-connect * - SceneDelegate: use .first (which returns nil in case there are no bookmarks) instead of bookmark(at: 0) (which crashes in case there are no bookmarks because the array is empty and the method tries to access an item at index 0) * added auto-connect after every setup, not only the first setup Co-authored-by: Felix Schwarz <fs-git@iospirit.com> * [feature/mdm-biometrical-unlock] MDM setting for Biometrical Unlock (#1058) * #4818 control via MDM to auto enable biometrical unlock * overwrites user defaults with MDM settings and use existing getter/setter; renamed MDM key to use-biometrical-unlock * - use user defaults for use-biometrical-unlock - show Face ID authorization immediately after enabling Face ID * [feature/hide-background-location-settings] Do not show Background Location section by default (#1051) * #1050 The Background Uploads section should be only shown, if Auto Upload Photos/Videos was enabled. Otherwise the setting section Background Uploads confuses the user, why the disabled options in this section could not be enabled. * fixed removing table view section * [fix/branding refinement] Branding: Color and UI Improvements (#1057) * Fixed branding issues * - fixed default searchBar background and placeholder text color for branded builds - show single account server list, if only one account is configured for branded and unbranded builds * - fixed default (unselected) tab bar color - added table view section border to branded account table view * - fixed rounded border for text fields in branded login UI - removed table row separator in branding login view - fixed colors in contrast mode, if tint color is white - fixed UIAlertView tint color * fixed tint color in UIAlertController in dark mode for branding colors * fixed color value again * fixed tint color in single account server list cell view * fixed missing profile UI * removed optional branding values (only two color values are now needed for a complete branding, all other values are optional) * fixed border color in single account server view, if navigationbar background color is white * added gomplate template for Branding.plist creation to the iOS repo adopted template for new Parameter and removed default values i template * fixed some color issues, if tint color is white * fixed setting custom UISearchBar backgroundColor on iOS 12 * set profile url as prefilled default value into setup url field * added a new color style loginStatusBarStyle to set a custom status bar style for the login view * if the key app.version-number exists, fastlane will use this value as app and extension short version number, which gives the possibility to set custom version numbers * Fixed CR findings: - added a protocol for setting the custom status bar style, instead of using static class names - using the correct SDK method for round rect * fixed merge error * [fix/branding-login-retry] Retry Section for Branded Login Error (#1047) * add a error section with a retry button in branded login view * #4786 added a retry interval of 10 seconds. In this time interval the app retries to establish the connection before a error message will be shown * only retry for network issues * only show retry section on network issues * - changed retry time interval to 30 seconds - retries minimum of 3 times * Update ownCloud/Static Login/Interface/StaticLoginSetupViewController.swift Co-authored-by: Felix Schwarz <fs-git@iospirit.com> * fixed connection retry and show retry section UI * HTTP pipeline is ready to schedule HTTP requests before the Static Login View Controller is brought up. Moved it before setting up the UIWindow * removed connection retries output and put it into the log Co-authored-by: Felix Schwarz <fs-git@iospirit.com> * [fix/single-accouont-display-name] Show Display Name in Branded Single Account View (#1049) * username could be like a uuid, which is not user readable. Instead now showing the displayName and if not available, the userName * fixed syntax error * fixed compile error * first draft for retrieving the user display name for the header view * retrieving the users display name by init a connection and reloading the table view * - new version and build number - new release notes entry * [feature/appstore-buildflag] Remove App Store / IAP code via build flag (#1052) * - add support and documentation for DISABLE_APPSTORE_LICENSING build flag * - ReleaseNotesHostViewController: remove unused reference to StoreKit - OCLicenseDuration: make sure SKProductSubscriptionPeriod conversion code is excluded when using the DISABLE_APPSTORE_LICENSING build flag * [fix/clear-lock] Clear lock when determining unlock expiry (#1061) * - AppLockmanager: clear unlock and lastApplicationBackgroundedDate in case an unlock has expired, to protect against subsequent attempts setting the device time to an earlier date * - AppLockManager: clear unlocked state if device time is earlier than lastBackgrounded time * - fix logic bug and improve structure * - AppLockManager: now returns correct unlock status when detecting that time was turned back * [feature/custom-app-scheme] Custom app/auth schemes (#1060) * - add support and documentation for DISABLE_APPSTORE_LICENSING build flag * - ReleaseNotesHostViewController: remove unused reference to StoreKit - OCLicenseDuration: make sure SKProductSubscriptionPeriod conversion code is excluded when using the DISABLE_APPSTORE_LICENSING build flag * - add support for app.custom-app-scheme and app.custom-auth-scheme to Fastfile - add documentation for new custom scheme Branding.plist parameters * - remove test values from Branding.plist * - move build options from `app.` space to `build.` space and rename options accordingly - add legacy support for previously used Branding.plist build customization option names - add `BuildOptions` class to `ownCloudApp` framework to make build customization options visible in documentation * - ensure BuildOptions class is actually loaded/initialized * - update Xcode to 12.5.1 for GitHub workflow configuration-documentation.yml * - adapt code in `ImportPasteboardAction.swift` to also compile in Xcode 12.4 * Configuration documentation updated Co-authored-by: felix-schwarz <felix-schwarz@users.noreply.github.com> Co-authored-by: Matthias Hühne <mhuehne@owncloud.com> * - switch to ios-sdk milestone/11.7.2 * add an accesibility id for the access files row, so that it can be matched by the autom tests * quote shell command, because it can contain spaces in path name * added public release notes for version 11.8.0 * fixed regression test findings * fixed toolbar visibility on iPad, if should not be shown * updated in-app changelog and added calens changelog entries * Calens changelog updated * - change SDK to 11.8 release * - updated fastlane release notes - changed changelog folder name * Calens changelog updated Co-authored-by: Felix Schwarz <fs-git@iospirit.com> Co-authored-by: felix-schwarz <felix-schwarz@users.noreply.github.com> Co-authored-by: Jesus Recio <jrecio@izertis.com> Co-authored-by: hosy <hosy@users.noreply.github.com>

username could be like a uuid, which is not user readable. Instead no…

77fe6c3

…w showing the displayName and if not available, the userName

hosy requested review from felix-schwarz and jesmrec October 14, 2021 13:58

hosy self-assigned this Oct 14, 2021

hosy added this to the 11.7.2-Fix milestone Oct 14, 2021

fixed syntax error

96ae32c

felix-schwarz approved these changes Oct 18, 2021

View reviewed changes

fixed compile error

aa4373d

hosy added 2 commits November 12, 2021 08:12

first draft for retrieving the user display name for the header view

2b52eb7

retrieving the users display name by init a connection and reloading …

d449b38

…the table view

jesmrec approved these changes Nov 16, 2021

View reviewed changes

jesmrec added the Approved by QA Approved by QA label Nov 16, 2021

fixed merge conflict with branch milestone/11.7.2

c9e1dbd

hosy merged commit 4b43863 into milestone/11.7.2 Nov 17, 2021

delete-merged-branch bot deleted the fix/single-account-display-name branch November 17, 2021 10:04

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[fix/single-accouont-display-name] Show Display Name in Branded Single Account View #1049

[fix/single-accouont-display-name] Show Display Name in Branded Single Account View #1049

hosy commented Oct 14, 2021

jesmrec commented Oct 19, 2021

hosy commented Oct 20, 2021

jesmrec commented Oct 21, 2021 •

edited

Loading

hosy commented Nov 8, 2021

felix-schwarz commented Nov 9, 2021

hosy commented Nov 9, 2021

felix-schwarz commented Nov 9, 2021

hosy commented Nov 15, 2021

jesmrec commented Nov 16, 2021

[fix/single-accouont-display-name] Show Display Name in Branded Single Account View #1049

[fix/single-accouont-display-name] Show Display Name in Branded Single Account View #1049

Conversation

hosy commented Oct 14, 2021

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

Checklist:

jesmrec commented Oct 19, 2021

hosy commented Oct 20, 2021

jesmrec commented Oct 21, 2021 • edited Loading

(1)

hosy commented Nov 8, 2021

felix-schwarz commented Nov 9, 2021

hosy commented Nov 9, 2021

felix-schwarz commented Nov 9, 2021

hosy commented Nov 15, 2021

jesmrec commented Nov 16, 2021

jesmrec commented Oct 21, 2021 •

edited

Loading