[feature/custom-app-scheme] Custom app/auth schemes

[felix-schwarz]

Description

• New Branding.plist options to change the schemes for private links:
  • build.custom-app-scheme to replace the default owncloud scheme
  • build.custom-auth-scheme to replace the default oc scheme
• Rename app.build-flags to build.flags

Example

To replace

• owncloud:// with cloudprivate://
• oc:// with cloudauth://

the following needs to be put in Branding.plist:

<key>build.custom-app-scheme</key>
<string>cloudprivate</string>
<key>build.custom-auth-scheme</key>
<string>cloudauth</string>

<key>authentication-oauth2.oa2-redirect-uri</key>
<string>cloudauth://ios.owncloud.com</string>
<key>authentication-oauth2.oidc-redirect-uri</key>
<string>cloudauth://ios.owncloud.com</string>

The options authentication-oauth2.oa2-redirect-uri and authentication-oauth2.oidc-redirect-uri are only needed if an external browser is used for OAuth2 and OIDC authentication.

Please see BUILD_CUSTOMIZATION.md for documentation and additional server-side considerations.

Related Issue

https://github.com/owncloud/enterprise/issues/4857

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ hosy
❌ felix-schwarz
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[felix-schwarz]

To clarify that these options are only available at build time, I moved all existing build options from the app. namespace to the build. namespace. Using options with the old name continues to work to avoid disruptions.

[jesmrec]

QA checks:

• use a custom scheme like myscheme:// to open a file
• use a custom scheme like myscheme:// to open a folder
• Change scheme for OAuth2/OIDC redirection
  • In server admin dashboard, create a new client with the customer scheme inside the redirection URL
  • Update code of class OCAuthenticationMethodOAuth2 with new clientID and secret, randomly created by server admin
  • Build via fastlane
  • Execute in device -> OAuth2 flow complete (assert 1)
  • Go to server admin dashboard and remove the recently registered client
  • Repeat the OAuth2 auth process -> Not posible, since the custom client id (including the scheme) is not registered anymore (assert 2)

fastlane command to build:

fastlane release_on_appstore create_release_notes:false create_screenshots:false build_regular_app:false build_emm_app:true deliver:false

NOTE: owncloud and oc schemes are totally replaced by the custom ones and no longer works after building with custom schemes.