[milestone/12.0] Version 12.0

[felix-schwarz]

Description

PR for version 12.0:

• built on top of feature/avatar because that branch already contains many changes
• code for < iOS 13.4 removed, now targeting iOS 13, upgrading to newer APIs where deprecated APIs were used
• PRs merged into this PR:
  • [feature/new-navigation] New navigation #1162
    • [feature/disable-fileprovider] Disable access to File Provider via MDM #1158
    • [feature/disallow-extensions] Add option to disallow extensions, show action for unviewable filetypes #1140
    • [feature/ats-control] Add DISABLE_PLAIN_HTTP build flag #1136
    • [feature/postbuild-settings] Postbuild Settings #1179
    • merge 11.11.0 and fastlane/enterprise-adhoc changes from master
  • [feature/css] CSS theming #1194
  • [feature/gridview] Gridview implementation (v12) #1195
  • [features/theme-json-icon] Dynamic Instance Logo #1196
  • [feature/new-sharing] New sharing UI with role support #1198
  • [feature/folder-savedsearch] Support saving folder searches #1205
  • [feature/v12-onboarding] Unified Onboarding and Account Setup (Vanilla and Branded) #1208

Related Issue

https://github.com/owncloud/ios-app/issues/1221)](https://github.com/owncloud/ios-app/issues/1221

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• My code follows the code style of this project.
• My change requires a change to the documentation.
• Added an issue with details about all relevant changes in the iOS documentation repository.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• All new and existing tests passed.
• Added changelog files for the fixed issues in folder changelog/unreleased

QA

Test plans:

Regression: https://github.com/owncloud/QA/blob/master/Mobile/iOS-app/Version%2012.0/Regression.md
Spaces: https://github.com/owncloud/QA/blob/master/Mobile/iOS-app/Version%2012.0/1101_spaces.md
Sharing in sidebar: https://github.com/owncloud/QA/blob/master/Mobile/iOS-app/Version%2012.0/Sharing-oCIS.md

(need merging)

Reports:

• (1) [LOW] Soft keyboard over the results [milestone/12.0] Version 12.0 #1095 (comment)
• (2) [HIGH] Reopening shows empty list of accounts [milestone/12.0] Version 12.0 #1095 (comment) [FIXED]
• (3) [LOW] Small indentation issue [milestone/12.0] Version 12.0 #1095 (comment) [FIXED]
• (4) [MED] Open links on folder does not open the folder [milestone/12.0] Version 12.0 #1095 (comment) [FIXED]
• (5) [MED] Download instead of streaming -> black screen [milestone/12.0] Version 12.0 #1095 (comment)
• (6) [LOW] Clipboard notification missing [milestone/12.0] Version 12.0 #1095 (comment) [FIXED]
• (7) [LOW] Full screen mode does not work properly [milestone/12.0] Version 12.0 #1095 (comment)
• (8) [LOW] Create folder icon repeated in share sheet [milestone/12.0] Version 12.0 #1095 (comment) [FIXED]
• (9) [MED] Offline indicator not gone after re-atuhenticate [milestone/12.0] Version 12.0 #1095 (comment)
• (10) [HIGH] Delete option missing in shared items inside an space [milestone/12.0] Version 12.0 #1095 (comment) [FIXED]
• (11) [MED] File not saved if created with a 3rd-party-app [milestone/12.0] Version 12.0 #1095 (comment) [FIXED]
• (12) [LOW] Sharing option duplicated in Files App [milestone/12.0] Version 12.0 #1095 (comment)
• (13) [HIGH] Incorrect list in Files app with the shared items [milestone/12.0] Version 12.0 #1095 (comment) [FIXED]
• (14) [LOW] Theme mapping [milestone/12.0] Version 12.0 #1095 (comment) [FIXED]
• (15) [MED] Paste option in space does nothing [milestone/12.0] Version 12.0 #1095 (comment) [FIXED]

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ hosy
❌ felix-schwarz
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[felix-schwarz]

@jesmrec #1220 fixes (1) and (7)

[felix-schwarz]

@jesmrec #1220 now also fixes (9)

[felix-schwarz]

@jesmrec #1220 now also fixes (12). That string is stored in the File Provider UI's Info.plist and therefore can't be changed dynamically at runtime. To keep it branding-friendly, I chose "Share by cloud" instead of "Share via ownCloud", "Share (ownCloud)", which would have required to customize both the Info.plist and the translations for branding.

[felix-schwarz]

@jesmrec finding (5) is also fixed in #1220 now