[milestone/12.0.1] Milestone 12.0.1

[felix-schwarz]

Description

Version 12.0.1 fixes all findings left over from version 12.0:

• (1) [LOW] Soft keyboard over the results [milestone/12.0] Version 12.0 #1095 (comment) [FIXED]
• (5) [MED] Download instead of streaming -> black screen [milestone/12.0] Version 12.0 #1095 (comment) [FIXED]
• (7) [LOW] Full screen mode does not work properly [milestone/12.0] Version 12.0 #1095 (comment) [FIXED]
• (9) [MED] Offline indicator not gone after re-atuhenticate [milestone/12.0] Version 12.0 #1095 (comment) [FIXED]
• (12) [LOW] Sharing option duplicated in Files App [milestone/12.0] Version 12.0 #1095 (comment) [FIXED]
• (13) [HIGH] Bottons misplaced [milestone/12.0.1] Milestone 12.0.1 #1220 (comment) [FIXED]

Regarding (12):

The string naming that action (Share) is stored in the File Provider UI's Info.plist and therefore can't be changed dynamically at runtime. To keep it branding-friendly, I chose "Share by cloud" instead of "Share via ownCloud", "Share (ownCloud)", which would have required to customize both the Info.plist and the translations for branding.

Related Issue

#1222

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• My code follows the code style of this project.
• My change requires a change to the documentation.
• Added an issue with details about all relevant changes in the iOS documentation repository.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• All new and existing tests passed.
• Added changelog files for the fixed issues in folder changelog/unreleased

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ hosy
❌ felix-schwarz
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[jesmrec]

(1), (7), (9) and (12) are fixed

About (5), i still reproduce it. I notice that a new Loading dialog is visible in streaming mode (cool!), but in download mode:

RPReplay_Final1686743044.MP4

File is downloading in the background bur black screen is there.

CC @felix-schwarz

[felix-schwarz]

@jesmrec Thanks for the video. The remaining issue from finding (5) should be fixed now, too.

[jesmrec]

(5) fixed

[jesmrec]

(13) [FIXED]

Feature: Copy/Move
Severity: High

1. Select any item and Copy or Move
2. Choose destination directory...
3. Files

Current: Copy Here / Move here buttons are misplaced and not clickable

Expected: correctly alligned and clickable

iPhone XR v16.5
ebd4c1ba85

EDIT: same behaviour in sharing:

[felix-schwarz]

@jesmrec (13) is fixed now, too.

[jesmrec]

Everything fixed