Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature/new-search] New search experience for version 12 #1142

Closed
wants to merge 68 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
68 commits
Select commit Hold shift + click to select a range
9ad6429
[milestone/11.8.2] Milestone 11.8.2 (#1085)
hosy Jan 17, 2022
eccd8d1
Add In House certificate option to resign README.md (#1084)
michaelstingl Jan 18, 2022
84c3b4c
Update release item with new download URL (#1067)
michaelstingl Jan 18, 2022
de3ca41
- switch to feature/graph-api SDK branch
felix-schwarz Feb 14, 2022
101d3b4
- adapt to new and updated APIs (OCPath -> OCDriveID + OCLocation)
felix-schwarz Feb 23, 2022
76c0a3f
- update iOS SDK
felix-schwarz Mar 7, 2022
b6b9bf9
Via SDK update:
felix-schwarz Mar 7, 2022
f1fac7b
[milestone/11.9.0] Milestone 11.9.0 (#1071)
hosy Mar 16, 2022
883d136
- update SDK to include latest Drive and Data Source changes
felix-schwarz Mar 23, 2022
70cdc22
[milestone/11.9.1] Milestone 11.9.1 (#1111)
felix-schwarz Mar 29, 2022
281bd98
updated app version number because of redundant AppStore build
Mar 29, 2022
420e5ff
[docs/folder-structure] Changed Docs Structure / MDM Fixes (#1094)
hosy Apr 4, 2022
55d415b
set up a new version 11.10.0
Apr 6, 2022
ace22e8
- progress snapshot, before refactoring DataSourceCollectionViewContr…
felix-schwarz Apr 6, 2022
71af450
- CollectionViewController: generalized collection view controller ba…
felix-schwarz Apr 7, 2022
a265ac4
- CollectionView: seperate classes in their own source files, clean u…
felix-schwarz Apr 8, 2022
867c787
[feature/openssl-1.1.1] Migration to OpenSSL 1.1.0 (#1116)
hosy Apr 8, 2022
d6ff1d7
- update SDK for improved error handling
felix-schwarz Apr 13, 2022
dc89f48
- CollectionView: make progress on modular structure and implementati…
felix-schwarz Apr 13, 2022
ee90fa4
Merge branch 'milestone/11.10.0' (at 'fix/copy-timeout') into branch
felix-schwarz Apr 13, 2022
491facd
- SDK update for new functionality
felix-schwarz Apr 21, 2022
4e14155
- ClientItemViewController+ItemActions: provide standard implementati…
felix-schwarz Apr 21, 2022
3036f54
- address code review findings by @hosy in https://github.com/ownclou…
felix-schwarz Apr 25, 2022
217ebe5
- switch to new UTType APIs
felix-schwarz Apr 25, 2022
dd3239b
- ownCloudTests: fix compilation issues due to API changes
felix-schwarz Apr 25, 2022
01edb55
- migrate app to Swift 5
felix-schwarz Apr 26, 2022
f36e18e
- update SDK
felix-schwarz Apr 26, 2022
5b86651
- ThemeWindow: add static property .frontmostThemeWindow
felix-schwarz Apr 26, 2022
8aaf59b
- add KNOWN_ISSUES.md to keep track of user-visible known issues alon…
felix-schwarz May 5, 2022
7a359a2
- File Provider: make sure actions work with OCItems, not OCVFSNodes …
felix-schwarz May 5, 2022
ccd1671
- ClientContext
felix-schwarz May 6, 2022
3bb3484
- ClientContext: add .originatingViewController property to pass the …
felix-schwarz May 9, 2022
e68ae02
[milestone/11.10.0] Milestone 11.10.0 (#1117)
hosy May 17, 2022
57d2dba
fixed link in changelog files, which causes that calens did not creat…
May 19, 2022
171987a
[fix/changelog-11.10.0] Fixed Changelog Date 11.10.0 (#1126)
hosy May 19, 2022
ccee161
- ownCloudAppFramework:
felix-schwarz May 24, 2022
633fb60
- File Provider: disallow deletion, renaming and moving of a space's …
felix-schwarz May 24, 2022
d6bf596
- bump version to 219
felix-schwarz May 24, 2022
b9e93fc
- FileProvider:
felix-schwarz May 26, 2022
47337b1
- AlertView: add support for text alignment
felix-schwarz May 27, 2022
de3af5e
- bump app version to 221
felix-schwarz May 27, 2022
0343980
- add OCDataItem+InteractionProtocols allow OCDataItems to provide ha…
felix-schwarz May 30, 2022
95a3bfd
- SortBarCell: WIP
felix-schwarz May 30, 2022
c74d316
- CollectionView:
felix-schwarz Jun 10, 2022
fa2e0dc
- ClientContext:
felix-schwarz Jun 20, 2022
ffe536c
- Action: add new .dropAction location and add relevant actions there
felix-schwarz Jun 21, 2022
152ad2f
- Search
felix-schwarz Jun 28, 2022
ea17262
- ItemListCell:
felix-schwarz Jun 29, 2022
edfd339
- SearchScope: set result count default from 2 (debug value) to 100 (…
felix-schwarz Jun 29, 2022
b5ea3d4
- update known issues, add new ideas regarding location picker, colle…
felix-schwarz Jun 30, 2022
42e612a
- MessageGroupCell: change order of "Apply to all" label and switch, …
felix-schwarz Jul 5, 2022
2d9c0b4
Merge remote-tracking branch 'origin/master' into feature/graph-api
felix-schwarz Jul 25, 2022
b59c62b
Fix code review findings from #1101.
felix-schwarz Jul 29, 2022
12a2813
- UITextField+Extension: extensions for UITextField and UISearchTextF…
felix-schwarz Aug 25, 2022
2f43dbd
- clean up and reorganize search base code into separate source code …
felix-schwarz Aug 25, 2022
2a49ecb
- CustomQuerySearchScope:
felix-schwarz Aug 25, 2022
7566c8f
- PopupButtonController: class making it easy to create and manage a …
felix-schwarz Aug 26, 2022
36ff86b
- Search
felix-schwarz Sep 14, 2022
fbd9f7b
Merge branch 'milestone/12.0' into feature/new-search
felix-schwarz Sep 14, 2022
c728227
- RoundCornerBackgroundView: new view class to simplify rendering cor…
felix-schwarz Sep 22, 2022
a02cf27
- update SDK
felix-schwarz Sep 22, 2022
bfbecba
- OCSavedSearch:
felix-schwarz Sep 23, 2022
1b1a804
- change "smart folders" naming to "search view"
felix-schwarz Sep 27, 2022
0655f06
- update SDK to fix issue with detached spaces' items turning up in s…
felix-schwarz Sep 28, 2022
4b5bbae
- update KNOWN_ISSUES.md to reflect changes
felix-schwarz Sep 29, 2022
9293375
- ItemSearchSuggestionsViewController:
felix-schwarz Sep 29, 2022
7e7ec32
- add SegmentView: composing items (SegmentViewItem) as views (Segmen…
felix-schwarz Sep 30, 2022
6e8fa6d
- update KNOWN_ISSUES evolution part with remaining idea on what can …
felix-schwarz Sep 30, 2022
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .swiftlint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ disabled_rules:
- function_parameter_count
- comment_spacing
- unused_closure_parameter
# - unneeded_notification_center_removal
- nesting
custom_rules:
empty_line_after_guard_statement:
included: ".*\\.swift"
Expand Down
5 changes: 3 additions & 2 deletions KNOWN_ISSUES.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ It should only be used with dedicated test servers, test data - and test devices
- subscription of spaces can't be turned on/off yet
- the root of spaces-based accounts is not yet shown as hierarchic sidebar
- support for sharing is widely untested and/or unavailable in the alpha
- inactivated state of spaces is not yet represented in the UI
- inactivated state of spaces is not yet represented in the UI (inactivated spaces are currently hidden instead)
- Copy & Paste allows copying a folder into a subfolder of its own / itself, leading to an infinite cycle
- handling of detached drives with user data in them (see OCVault.detachedDrives)
- sync actions that are actually complete are not always cleared from the Status tab until a logout/login
Expand All @@ -24,12 +24,13 @@ It should only be used with dedicated test servers, test data - and test devices
- dragging an entire space on top of another starts a full copy of the space, which eventually fails halfway through

## SDK
- local storage consumed by spaces that are then deleted or inactivated is not reclaimed
- pre-population of accounts using infinite PROPFIND is not supported

# Evolution roadmap
- collection views
- support sidebars / hierarchies, including expanded state, with dynamic updates from data sources
- ItemListCell: replace manual composition of info line below name with SegmentView
- allows to show different content there, f.ex. Space and Folder in search

- location picker replaces folder picker
- supports picking
Expand Down
2 changes: 1 addition & 1 deletion ios-sdk
Submodule ios-sdk updated 73 files
+11 −0 CHANGELOG.md
+86 −2 ownCloudSDK.xcodeproj/project.pbxproj
+1 −0 ownCloudSDK/App Identity/OCAppIdentity.h
+62 −0 ownCloudSDK/App Providers/OCAppProvider.h
+162 −0 ownCloudSDK/App Providers/OCAppProvider.m
+52 −0 ownCloudSDK/App Providers/OCAppProviderApp.h
+103 −0 ownCloudSDK/App Providers/OCAppProviderApp.m
+50 −0 ownCloudSDK/App Providers/OCAppProviderFileType.h
+60 −0 ownCloudSDK/App Providers/OCAppProviderFileType.m
+3 −1 ownCloudSDK/Categories/Foundation/NSArray+OCMapping.h
+19 −2 ownCloudSDK/Categories/Foundation/NSArray+OCMapping.m
+1 −1 ownCloudSDK/Categories/Foundation/NSArray+ObjCRuntime.m
+2 −0 ownCloudSDK/Categories/Foundation/NSDate+OCDateParser.h
+23 −0 ownCloudSDK/Categories/Foundation/NSDate+OCDateParser.m
+5 −0 ownCloudSDK/Connection/Capabilities/OCCapabilities.h
+73 −0 ownCloudSDK/Connection/Capabilities/OCCapabilities.m
+31 −0 ownCloudSDK/Connection/NSError+OCISError.h
+76 −0 ownCloudSDK/Connection/NSError+OCISError.m
+364 −0 ownCloudSDK/Connection/OCConnection+AppProviders.m
+17 −1 ownCloudSDK/Connection/OCConnection+Tools.m
+23 −0 ownCloudSDK/Connection/OCConnection.h
+4 −0 ownCloudSDK/Connection/OCConnection.m
+1 −0 ownCloudSDK/Core/Data Sources/OCCore+DataSources.h
+5 −0 ownCloudSDK/Core/Data Sources/OCCore+DataSources.m
+5 −0 ownCloudSDK/Core/OCCore.h
+116 −151 ownCloudSDK/Core/OCCore.m
+1 −0 ownCloudSDK/Core/Resources/Resource/OCResource.h
+1 −0 ownCloudSDK/Core/Resources/Resource/OCResource.m
+36 −0 ownCloudSDK/Core/Resources/URLItems/OCResourceRequestURLItem.h
+73 −0 ownCloudSDK/Core/Resources/URLItems/OCResourceRequestURLItem.m
+29 −0 ownCloudSDK/Core/Resources/URLItems/OCResourceSourceURLItems.h
+136 −0 ownCloudSDK/Core/Resources/URLItems/OCResourceSourceURLItems.m
+1 −1 ownCloudSDK/Core/Sync/Actions/CopyMove/OCSyncActionCopyMove.m
+4 −1 ownCloudSDK/Core/Sync/Actions/Delete/OCSyncActionDelete.m
+1 −0 ownCloudSDK/Data Sources/OCDataTypes.h
+1 −0 ownCloudSDK/Data Sources/OCDataTypes.m
+5 −4 ownCloudSDK/Drive/OCDrive.h
+2 −1 ownCloudSDK/Drive/OCDrive.m
+4 −1 ownCloudSDK/Errors/NSError+OCError.h
+8 −0 ownCloudSDK/Errors/NSError+OCError.m
+5 −1 ownCloudSDK/Extensions/OCExtensionManager.h
+79 −0 ownCloudSDK/Extensions/OCExtensionManager.m
+1 −1 ownCloudSDK/File Handling/Checksums/OCChecksumAlgorithmSHA1.m
+29 −0 ownCloudSDK/HTTP/Request/NSDictionary+OCFormEncoding.h
+40 −0 ownCloudSDK/HTTP/Request/NSDictionary+OCFormEncoding.m
+1 −0 ownCloudSDK/HTTP/Request/OCHTTPDAVRequest.m
+1 −0 ownCloudSDK/HTTP/Request/OCHTTPRequest.h
+3 −16 ownCloudSDK/HTTP/Request/OCHTTPRequest.m
+10 −0 ownCloudSDK/Item/OCItem+OCFileURLMetadata.h
+10 −0 ownCloudSDK/Item/OCItem+OCFileURLMetadata.m
+37 −0 ownCloudSDK/Item/OCItem+OCTypeAlias.h
+167 −0 ownCloudSDK/Item/OCItem+OCTypeAlias.m
+2 −1 ownCloudSDK/Item/OCItem.h
+1 −0 ownCloudSDK/Item/OCItem.m
+1 −0 ownCloudSDK/OCMacros.h
+4 −0 ownCloudSDK/OCTypes.h
+4 −0 ownCloudSDK/Query/Condition/OCQueryCondition.h
+4 −0 ownCloudSDK/Query/Condition/OCQueryCondition.m
+9 −0 ownCloudSDK/Resources/en.lproj/Localizable.strings
+148 −0 ownCloudSDK/Vaults/Database/OCDatabase+Schemas.m
+3 −3 ownCloudSDK/Vaults/Database/OCDatabase.h
+58 −0 ownCloudSDK/Vaults/Database/OCDatabase.m
+1 −0 ownCloudSDK/Vaults/Database/SQLite/OCSQLiteDB.h
+6 −0 ownCloudSDK/Vaults/Database/SQLite/OCSQLiteDB.m
+3 −0 ownCloudSDK/Vaults/OCVault+Internal.h
+3 −0 ownCloudSDK/Vaults/OCVault+Internal.m
+15 −1 ownCloudSDK/Vaults/OCVault.h
+275 −33 ownCloudSDK/Vaults/OCVault.m
+7 −0 ownCloudSDK/ownCloudSDK.h
+24 −0 ownCloudSDKTests/ConnectionTests.m
+3 −3 ownCloudSDKTests/DataSourceTests.m
+4 −0 ownCloudSDKTests/OCTestTarget.h
+10 −0 ownCloudSDKTests/OCTestTarget.m
174 changes: 164 additions & 10 deletions ownCloud.xcodeproj/project.pbxproj

Large diffs are not rendered by default.

13 changes: 11 additions & 2 deletions ownCloud.xcworkspace/xcshareddata/swiftpm/Package.resolved
Original file line number Diff line number Diff line change
@@ -1,5 +1,14 @@
{
"pins" : [
{
"identity" : "down",
"kind" : "remoteSourceControl",
"location" : "https://github.com/johnxnguyen/Down",
"state" : {
"branch" : "master",
"revision" : "e754ab1c80920dd51a8e08290c912ac1c2ac8b58"
}
},
{
"identity" : "openssl",
"kind" : "remoteSourceControl",
Expand All @@ -14,8 +23,8 @@
"kind" : "remoteSourceControl",
"location" : "https://github.com/microsoft/plcrashreporter.git",
"state" : {
"revision" : "4637a7854de2cc5c354d46fb931d74bdbc2c043e",
"version" : "1.7.0"
"revision" : "81cdec2b3827feb03286cb297f4c501a8eb98df1",
"version" : "1.10.2"
}
},
{
Expand Down
19 changes: 19 additions & 0 deletions ownCloud/Resources/en.lproj/Localizable.strings
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,13 @@
"size" = "size";
"date" = "date";
"Search folder" = "Search folder";
"Search tree" = "Search tree";
"Search from {{folder.name}}" = "Search from {{folder.name}}";
"Search space" = "Search space";
"Search {{space.name}}" = "Search {{space.name}}";
"Search account" = "Search account";
"Save search" = "Save search";

"Pending" = "Pending";
"Show parent paths" = "Show parent paths";
"Reveal in folder" = "Reveal in folder";
Expand All @@ -117,6 +123,17 @@

"Show more results" = "Show more results";

/* Saved searches */
"Saved search views" = "Saved search views";
"Saved search templates" = "Saved search templates";
"Save as search view" = "Save as search view";
"Save as search template" = "Save as search template";

"Name of view" = "Name of view";
"Search view" = "Search view";
"Name of template" = "Name of template";
"Search template" = "Search template";

/* Search scope */
"Search scope" = "Search scope";
"Toggle Search Scope" = "Toggle Search Scope";
Expand All @@ -142,6 +159,7 @@

/* Client Messages */
"Empty folder" = "Empty folder";
"No contents" = "No contents";
"This folder contains no files or folders." = "This folder contains no files or folders.";
"This folder is empty. Fill it with content:" = "This folder is empty. Fill it with content:";

Expand All @@ -160,6 +178,7 @@
"Upload files" = "Upload files";

"No matches" = "No matches";
"The search term you entered did not match any item in the selected scope." = "The search term you entered did not match any item in the selected scope.";
"There are no results for this search term" = "There are no results for this search term";
"Status" = "Status";

Expand Down
68 changes: 68 additions & 0 deletions ownCloudAppFramework/Resources/en.lproj/Localizable.strings
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,11 @@
"keyword_folder" = "folder";
"keyword_image" = "image";
"keyword_video" = "video";
"keyword_audio" = "audio";
"keyword_document" = "document";
"keyword_spreadsheet" = "spreadsheet";
"keyword_presentation" = "presentation";
"keyword_pdf" = "pdf";
"keyword_today" = "today";
"keyword_week" = "week";
"keyword_month" = "month";
Expand All @@ -64,3 +69,66 @@
"keyword_w" = "w"; /* short-form for "week" */
"keyword_m" = "m"; /* short-form for "month" */
"keyword_y" = "y"; /* short-form for "year" */

/* Search token labels */
"No folder" = "No folder";
"Folder" = "Folder";

"No file" = "No file";
"File" = "File";

"No image" = "No image";
"Image" = "Image";

"No video" = "No video";
"Video" = "Video";

"No audio" = "No audio";
"Audio" = "Audio";

"Document" = "Document";
"No Document" = "No Document";

"Spreadsheet" = "Spreadsheet";
"No spreadsheet" = "No spreadsheet";

"Presentation" = "Presentation";
"No presentation" = "No presentation";

"PDF" = "PDF";
"No PDF" = "No PDF";

"Before" = "Before";
"After" = "After";

"Not on" = "Not on";
"On" = "On";
"Not" = "Not";

"Before today" = "Before today";
"Before yesterday" = "Before yesterday";
">%d days ago" = ">%d days ago";
"Today" = "Today";
"Since yesterday" = "Since yesterday";
"Last %d days" = "Last %d days";

"Before this week" = "Before this week";
"Before last week" = "Before last week";
">%d weeks ago" = ">%d weeks ago";
"This week" = "This week";
"Since last week" = "Since last week";
"Last %d weeks" = "Last %d weeks";

"Before this month" = "Before this month";
"Before last month" = "Before last month";
"> %d months ago" = "> %d months ago";
"This month" = "This month";
"Since last month" = "Since last month";
"Last %d months" = "Last %d months";

"Before this year" = "Before this year";
"Before last year" = "Before last year";
"> %d years ago" = "> %d years ago";
"This year" = "This year";
"Since last year" = "Since last year";
"Last %d years" = "Last %d years";

This file was deleted.

Loading