Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Confusing NOTIFICATIONS_SMTP_ENCRYPTION setting #7345

Closed
xoxys opened this issue Sep 25, 2023 · 0 comments
Closed

Confusing NOTIFICATIONS_SMTP_ENCRYPTION setting #7345

xoxys opened this issue Sep 25, 2023 · 0 comments
Assignees
@rhafer
Labels
Type:Bug

Comments

@xoxys
Copy link
Contributor

xoxys commented Sep 25, 2023 •
edited
Loading

Describe the bug

Infinitescale has implemented all encryption methods (incl. deprecated ones) from https://github.com/xhit/go-simple-mail/blob/master/email.go#L84-L95

As EncryptionSSL is the deprecated but equal variant of EncryptionSSLTLS and EncryptionTLS of EncryptionSTARTTLS It's pretty confusing to allow users to set all of them including the deprecated and therefor duplicated methods:

Encryption method for the SMTP communication. Possible values  are 'starttls', 'ssl', 'ssltls', 'tls'  and 'none'.

Expected behavior

Users should only be able to select the two available SMTP encryption methods ssl/tls and starttls or none.
@xoxys xoxys added the Type:Bug label Sep 25, 2023
@xoxys xoxys mentioned this issue Sep 26, 2023
Closed
@rhafer rhafer self-assigned this Sep 26, 2023
rhafer added a commit to rhafer/ocis that referenced this issue Sep 26, 2023
@rhafer
notifications: Deprecate redundant encryptions settings
57fe5bd 
'tls' and 'ssl' are duplicates of 'starttls' and 'ssltls' and have been deprecated
in the upstream modules we use for sending mail notifications. Let's deprecate them
as well and issue a warning when they are still used.

Fixes: owncloud#7345
@rhafer rhafer mentioned this issue Sep 26, 2023
Merged
rhafer added a commit to rhafer/ocis that referenced this issue Sep 27, 2023
@rhafer
notifications: Deprecate redundant encryptions settings
2079434 
'tls' and 'ssl' are duplicates of 'starttls' and 'ssltls' and have been deprecated
in the upstream modules we use for sending mail notifications. Let's deprecate them
as well and issue a warning when they are still used.

Fixes: owncloud#7345
rhafer added a commit to rhafer/ocis that referenced this issue Sep 27, 2023
@rhafer
notifications: Deprecate redundant encryptions settings
0f60025 
'tls' and 'ssl' are duplicates of 'starttls' and 'ssltls' and have been deprecated
in the upstream modules we use for sending mail notifications. Let's deprecate them
as well and issue a warning when they are still used.

Fixes: owncloud#7345
rhafer added a commit to rhafer/ocis that referenced this issue Sep 27, 2023
@rhafer
notifications: Deprecate redundant encryptions settings
e9aa895 
'tls' and 'ssl' are duplicates of 'starttls' and 'ssltls' and have been deprecated
in the upstream modules we use for sending mail notifications. Let's deprecate them
as well and issue a warning when they are still used.

Fixes: owncloud#7345
rhafer added a commit to rhafer/ocis that referenced this issue Sep 28, 2023
@rhafer
notifications: Deprecate redundant encryptions settings
28f2754 
'tls' and 'ssl' are duplicates of 'starttls' and 'ssltls' and have been deprecated
in the upstream modules we use for sending mail notifications. Let's deprecate them
as well and issue a warning when they are still used.

Fixes: owncloud#7345
rhafer added a commit to rhafer/ocis that referenced this issue Sep 28, 2023
@rhafer
notifications: Deprecate redundant encryptions settings
9cbf169 
'tls' and 'ssl' are duplicates of 'starttls' and 'ssltls' and have been deprecated
in the upstream modules we use for sending mail notifications. Let's deprecate them
as well and issue a warning when they are still used.

Fixes: owncloud#7345
rhafer added a commit to rhafer/ocis that referenced this issue Oct 5, 2023
@rhafer
notifications: Deprecate redundant encryptions settings
408cb15 
'tls' and 'ssl' are duplicates of 'starttls' and 'ssltls' and have been deprecated
in the upstream modules we use for sending mail notifications. Let's deprecate them
as well and issue a warning when they are still used.

Fixes: owncloud#7345
@rhafer rhafer closed this as completed in 246ec1e Oct 5, 2023
@micbar micbar mentioned this issue Dec 12, 2023
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rhafer rhafer

Labels
Type:Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rhafer @xoxys