notifcations: Sanitize SMTP configuration #7361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xoxys
reviewed
Sep 27, 2023
rhafer
force-pushed
the
issue/7356
branch
2 times, most recently
from
143be87
to
6c676c1
Compare
rhafer
force-pushed
the
issue/7356
branch
3 times, most recently
from
e58084c
to
83800a9
Compare
mmattel
reviewed
Oct 5, 2023
'tls' and 'ssl' are duplicates of 'starttls' and 'ssltls' and have been deprecated in the upstream modules we use for sending mail notifications. Let's deprecate them as well and issue a warning when they are still used. Fixes: owncloud#7345
dragonchaser
approved these changes
Oct 5, 2023
dragonchaser
approved these changes
Oct 5, 2023
This introduces the new value `auto` for NOTIFICATIONS_SMTP_AUTHENTICATION. Which will make the notifications service automatically pick an authentication mechanism that the server supports. This is also the new default behavior. This also removes most of the other default settings for the SMTP configuration. The default values were of no real use for this service. Closes: owncloud#7356
rhafer
requested review from
wkloucek,
phil-davis and
individual-it
as code owners
micbar
approved these changes
Oct 5, 2023
|
Kudos, SonarCloud Quality Gate passed! |
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes a couple changes to the Mail client configuration of the notifications service
Please specifically review the deprecation notice. As were not deprecating a whole config variable but just specific configuration settings.
Closes: #7356 #7345