Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename Konnectd to IDP #1390

Merged
merged 3 commits into from
Jan 29, 2021
Merged

Rename Konnectd to IDP #1390

merged 3 commits into from
Jan 29, 2021

Conversation

IljaN
Copy link
Member

@IljaN IljaN commented Jan 22, 2021 •
edited
Loading

Description

Part of product name removal for a domain-driven naming

Related Issue

Issue: To be found

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

@IljaN IljaN self-assigned this Jan 22, 2021
@phil-davis
Copy link
Contributor

https://drone.owncloud.com/owncloud/ocis/2856/73/7

Some accounts UI test fails, for example:

Timed out while waiting for element <//table//td[text()="konnectd"]> to be present for 20000 milliseconds. - expected "visible" but got: "not found" (20009ms)
undefined    ✖ failed
      Timed out while waiting for element <//table//td[text()="konnectd"]> to be present for 20000 milliseconds. - expected "visible" but got: "not found" (20009ms)
          at Proxy._callee2$ (/drone/src/accounts/ui/tests/acceptance/pageobjects/accountsPage.js:18:29)
          at new Promise (<anonymous>)
          at Proxy.isUserListed (/drone/src/accounts/ui/tests/acceptance/pageobjects/accountsPage.js:16:17)
          at _callee$ (/drone/src/accounts/ui/tests/acceptance/stepDefinitions/accountsContext.js:11:55)

I guess there are more konnectd to sort out.

wkloucek
wkloucek requested changes Jan 22, 2021
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
changelog/1.0.0_2020-12-17/update-konnectd.md Outdated Show resolved Hide resolved
changelog/unreleased/add-ocis-url-env.md Outdated Show resolved Hide resolved
@IljaN
Copy link
Member Author

IljaN commented Jan 22, 2021

@wkloucek Thanks for review :)

@IljaN IljaN requested a review from wkloucek January 22, 2021 17:02
wkloucek
wkloucek requested changes Jan 22, 2021
View reviewed changes
Copy link
Contributor

@wkloucek wkloucek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also change the page title in https://github.com/owncloud/ocis/blob/rename-konnectd-to-idp/docs/extensions/idp/_index.md

docs/ocis/deployment/ocis_keycloak.md
@@ -19,7 +19,7 @@ geekdocFilePath: ocis_keycloak.md

The docker stack consists 4 containers. One of them is Traefik, a proxy which is terminating ssl and forwards the requests to oCIS in the internal docker network.

Keykloak add two containers: Keycloak itself and a PostgreSQL as database. Keycloak will be configured as oCIS' IDP instead of the internal IDP [Konnectd]({{< ref "../../extensions/konnectd/_index.md" >}})
Keykloak add two containers: Keycloak itself and a PostgreSQL as database. Keycloak will be configured as oCIS' IDP instead of the internal IDP [Konnectd]({{< ref "../../extensions/idp/_index.md" >}})
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we leave Konnectd here? Could be confusing since we don't call it like this somewhere else? I would just call it the "default IDP shipped with oCIS" or "oCIS IDP" since it got no precise name anymore.

@IljaN IljaN force-pushed the rename-konnectd-to-idp branch 2 times, most recently from ed79e26 to d1b3614 Compare January 29, 2021 10:14
@IljaN IljaN requested a review from wkloucek January 29, 2021 10:15
phil-davis
phil-davis reviewed Jan 29, 2021
View reviewed changes
Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.github/dependabot.yml is a new file and mentions "/konnectd" - I guess that reference should be renamed.

@sonarcloud
Copy link

sonarcloud bot commented Jan 29, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@IljaN IljaN merged commit 4aea7a9 into master Jan 29, 2021
@delete-merged-branch delete-merged-branch bot deleted the rename-konnectd-to-idp branch January 29, 2021 11:31
This was referenced Jan 29, 2021
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wkloucek wkloucek wkloucek approved these changes

@phil-davis phil-davis phil-davis approved these changes

@individual-it individual-it Awaiting requested review from individual-it individual-it is a code owner

@LukasHirt LukasHirt Awaiting requested review from LukasHirt

@micbar micbar Awaiting requested review from micbar micbar is a code owner

Assignees

@IljaN IljaN

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@IljaN @phil-davis @wkloucek