Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bring back identifier-registration.yaml, strip commented stuff, rebuild embed.go #1568

Merged
merged 1 commit into from
Feb 1, 2021
Merged

bring back identifier-registration.yaml, strip commented stuff, rebuild embed.go #1568

merged 1 commit into from
Feb 1, 2021

Conversation

wkloucek
Copy link
Contributor

@wkloucek wkloucek commented Jan 29, 2021 •
edited
Loading

Description

konnectd/assets/identifier-registration.yaml was removed in #1390 but should have been moved to idp/assets/identifier-registration.yaml

This PR brings back the file, removes commented stuff from that file. In order to build the embed.go file in CI, also the Makefile and CI was fixed.

Related Issue

Motivation and Context

How Has This Been Tested?

  • local test -> login possible

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@update-docs
Copy link

update-docs bot commented Jan 29, 2021

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@wkloucek wkloucek force-pushed the bring_back_identifier-registration.yaml branch from 0dd2aa3 to a183668 Compare January 29, 2021 18:03
@wkloucek wkloucek changed the title bring back identifier-registration.yaml, strip commented stuff, fix makefile and rebuild bring back identifier-registration.yaml, strip commented stuff, build embed.go in CI Jan 29, 2021
@IljaN IljaN self-requested a review January 29, 2021 19:10
@phil-davis
Copy link
Contributor

https://drone.owncloud.com/owncloud/ocis/3142/75/2
docker-arm: Error response from daemon: No such image: owncloudci/nodejs:12
It looks like https://hub.docker.com/r/owncloudci/nodejs/tags?page=1&ordering=last_updated is only amd64

@wkloucek wkloucek force-pushed the bring_back_identifier-registration.yaml branch 2 times, most recently from 1a43c2b to 194a168 Compare February 1, 2021 12:58
@wkloucek wkloucek force-pushed the bring_back_identifier-registration.yaml branch from 194a168 to 686f496 Compare February 1, 2021 13:34
@wkloucek wkloucek changed the title bring back identifier-registration.yaml, strip commented stuff, build embed.go in CI bring back identifier-registration.yaml, strip commented stuff, rebuild embed.go Feb 1, 2021
@wkloucek wkloucek marked this pull request as ready for review February 1, 2021 13:35
@wkloucek
Copy link
Contributor Author

wkloucek commented Feb 1, 2021

CI related part moved to #1580

@sonarcloud
Copy link

sonarcloud bot commented Feb 1, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@wkloucek wkloucek merged commit bb05da0 into master Feb 1, 2021
@delete-merged-branch delete-merged-branch bot deleted the bring_back_identifier-registration.yaml branch February 1, 2021 16:04
ownclouders pushed a commit that referenced this pull request Feb 1, 2021
@wkloucek
commit bb05da0
a8af93b 
Merge: 35f7cd5 686f496
Author: Willy Kloucek <34452982+wkloucek@users.noreply.github.com>
Date:   Mon Feb 1 17:04:48 2021 +0100

    Merge pull request #1568 from owncloud/bring_back_identifier-registration.yaml

    bring back identifier-registration.yaml, strip commented stuff, rebuild embed.go
This was referenced Feb 1, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IljaN IljaN IljaN approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wkloucek @phil-davis @IljaN