Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

generate all protobuf and embed.go files in CI #1580

Merged
merged 6 commits into from
Feb 16, 2021
Merged

generate all protobuf and embed.go files in CI #1580

merged 6 commits into from
Feb 16, 2021

Conversation

wkloucek
Copy link
Contributor

@wkloucek wkloucek commented Feb 1, 2021 •
edited
Loading

Description

  • Ci now runs a "ci-node-generate" and a "ci-go-generate" step for each oCIS module instead the "frontend" task for selective modules
  • rework all makefile sections related to protobuf generation, yarn build and docs generation
  • before building / testing oCIS all embed.go and protobuf definitions are now beeing generated
  • now swagger documentation is generated for all .proto files
  • now documentation on owncloud.github.io is generated for all .proto files (like it has been the case for https://owncloud.github.io/extensions/thumbnails/grpc/)

Related Issue

Motivation and Context

  • Embed.go and protobuf files have been outdated.
  • Changes have not been tested in CI
  • Documentation was not generated or properly refreshed

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • generate and commit updated protobuf and embed.go files after this PR has been merged

@update-docs
Copy link

update-docs bot commented Feb 1, 2021

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@wkloucek wkloucek mentioned this pull request Feb 1, 2021
Merged
9 tasks
@wkloucek wkloucek force-pushed the build_idp_embed_ci branch 2 times, most recently from 017161b to 3a4caa3 Compare February 1, 2021 17:58
@wkloucek wkloucek marked this pull request as ready for review February 2, 2021 09:46
@wkloucek wkloucek requested a review from kulmann February 3, 2021 07:43
@wkloucek wkloucek force-pushed the build_idp_embed_ci branch 2 times, most recently from 9c5f2e1 to 6b21215 Compare February 3, 2021 10:23
@wkloucek wkloucek marked this pull request as draft February 3, 2021 10:36
@wkloucek wkloucek force-pushed the build_idp_embed_ci branch 14 times, most recently from ba0f824 to 0c6bebe Compare February 4, 2021 09:44
@wkloucek wkloucek changed the title Build idp embed ci generate files in CI Feb 4, 2021
@wkloucek wkloucek changed the title generate files in CI generate all protobuf and embed.go files in CI Feb 4, 2021
@wkloucek wkloucek marked this pull request as ready for review February 4, 2021 11:57
@wkloucek wkloucek requested a review from refs February 4, 2021 11:57
@wkloucek wkloucek force-pushed the build_idp_embed_ci branch 2 times, most recently from 07d66d5 to 02cde82 Compare February 11, 2021 08:11
kulmann
kulmann approved these changes Feb 15, 2021
View reviewed changes
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! Needs a rebase now, but good stuff! 🚀

@sonarcloud
Copy link

sonarcloud bot commented Feb 16, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@wkloucek wkloucek merged commit 6ee83ba into master Feb 16, 2021
@delete-merged-branch delete-merged-branch bot deleted the build_idp_embed_ci branch February 16, 2021 17:38
ownclouders pushed a commit that referenced this pull request Feb 16, 2021
@wkloucek
commit 6ee83ba
4a9ec78 
Merge: 67eb5ce b0ca23f
Author: Willy Kloucek <34452982+wkloucek@users.noreply.github.com>
Date:   Tue Feb 16 18:38:47 2021 +0100

    Merge pull request #1580 from owncloud/build_idp_embed_ci

    generate all protobuf and embed.go files in CI
@kulmann kulmann mentioned this pull request Feb 17, 2021
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulmann kulmann kulmann approved these changes

@individual-it individual-it Awaiting requested review from individual-it individual-it is a code owner

@LukasHirt LukasHirt Awaiting requested review from LukasHirt

@micbar micbar Awaiting requested review from micbar micbar is a code owner

@phil-davis phil-davis Awaiting requested review from phil-davis phil-davis is a code owner

@refs refs Awaiting requested review from refs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wkloucek @kulmann