Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update web to 2.0.0 #1661

Merged
merged 6 commits into from
Feb 17, 2021
Merged

Update web to 2.0.0 #1661

merged 6 commits into from
Feb 17, 2021

Conversation

kulmann
Copy link
Member

@kulmann kulmann commented Feb 16, 2021

Description

Update ownCloud Web to v2.0.0

Related Issue

Motivation and Context

Release

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@kulmann kulmann self-assigned this Feb 16, 2021
@kulmann kulmann mentioned this pull request Feb 16, 2021
16 tasks
Copy link
Collaborator

@LukasHirt LukasHirt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is generating the assets manually still required since #1580 got merged?

@LukasHirt
Copy link
Collaborator

Btw, requires #1597

@kulmann
Copy link
Member Author

kulmann commented Feb 17, 2021

Is generating the assets manually still required since #1580 got merged?

For trying it locally, yes. For having it up to date in the repo after merge, no AFAIK.

@wkloucek
Copy link
Contributor

Is generating the assets manually still required since #1580 got merged?

For trying it locally, yes. For having it up to date in the repo after merge, no AFAIK.
Actually the generated files still should be commited as long as we don't have this as an automatic step after a merge to master. But we are building them automatically in CI too, in order to ensure that our binaries represent the code (if somebody forgot to commit the generated files)

@LukasHirt
Copy link
Collaborator

Actually the generated files still should be commited as long as we don't have this as an automatic step after a merge to master. But we are building them automatically in CI too, in order to ensure that our binaries represent the code (if somebody forgot to commit the generated files)

Ah, okay. I thought the process now will be:

  • if working locally pull latest changes and generate
  • if pushing, do not commit the generated files and let CI take care of that

@wkloucek
Copy link
Contributor

Actually the generated files still should be commited as long as we don't have this as an automatic step after a merge to master. But we are building them automatically in CI too, in order to ensure that our binaries represent the code (if somebody forgot to commit the generated files)

Ah, okay. I thought the process now will be:

  • if working locally pull latest changes and generate
  • if pushing, do not commit the generated files and let CI take care of that

I would not like this since always generating them before developing is time consuming. Also the need do be used from external extensions and therefore be present in the git repository. It was just the first step do generate them also in CI. Auto commiting them after merge to master needs some more changes and time.

@sonarcloud
Copy link

sonarcloud bot commented Feb 17, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@kulmann kulmann merged commit 22ef448 into master Feb 17, 2021
@delete-merged-branch delete-merged-branch bot deleted the web-2.0.0 branch February 17, 2021 10:41
ownclouders pushed a commit that referenced this pull request Feb 17, 2021
Merge: b4fe7de ca46b1a
Author: Benedikt Kulmann <benedikt@kulmann.biz>
Date:   Wed Feb 17 11:41:57 2021 +0100

    Merge pull request #1661 from owncloud/web-2.0.0

    Update web to 2.0.0
ownclouders pushed a commit that referenced this pull request Feb 17, 2021
Merge: b4fe7de ca46b1a
Author: Benedikt Kulmann <benedikt@kulmann.biz>
Date:   Wed Feb 17 11:41:57 2021 +0100

    Merge pull request #1661 from owncloud/web-2.0.0

    Update web to 2.0.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants