Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trigger CI #1972

Closed
wants to merge 1 commit into from
Closed

Trigger CI #1972

wants to merge 1 commit into from

Conversation

phil-davis
Copy link
Contributor

Because I don't believe the unexpected test failure issue owncloud/core#38657 that is happening in PR #1970 is due to the bump of the commit id.

Let's see what happens in current master.

@phil-davis
Trigger CI
3e9b666 
Because I don't believe the unexpected test failure issue owncloud/core#38657 that is happening in PR #1970 is due to the bump of the commit id.
@phil-davis phil-davis self-assigned this Apr 27, 2021
@owncloud owncloud deleted a comment from update-docs bot Apr 27, 2021
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@phil-davis
Copy link
Contributor Author

https://drone.owncloud.com/owncloud/ocis/4725/36/7

runsh: Total unexpected failed scenarios throughout the test run:
apiTrashbin/trashbinFilesFolders.feature:201
apiTrashbin/trashbinFilesFolders.feature:202

That fails in master! How did that happen? I will investigate.

@phil-davis
Copy link
Contributor Author

phil-davis commented Apr 27, 2021 •
edited
Loading

They were removed from the expected-failures file yesterday by commit 26ee19d

@refs how did that commit get on the head of master branch? I don't see a matching PR.

@refs
Copy link
Member

refs commented Apr 27, 2021

@refs how did that commit get on the head of master branch? I don't see a matching PR.

I honestly have no idea how that commit got into master 😅 it was definitely me, but master has branch protection, so I have no clue how that got in

@phil-davis
Copy link
Contributor Author

@refs PR to revert: #1973 - please review.

@phil-davis
Copy link
Contributor Author

See #1973 for the fix.

@phil-davis phil-davis closed this Apr 27, 2021
@phil-davis phil-davis deleted the phil-davis-patch-1 branch April 27, 2021 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@phil-davis phil-davis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@phil-davis @refs