Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only] Revert "adjust expected failures for ocis" #1973

Merged
merged 1 commit into from
Apr 27, 2021
Merged

[tests-only] Revert "adjust expected failures for ocis" #1973

merged 1 commit into from
Apr 27, 2021

Conversation

phil-davis
Copy link
Contributor

@phil-davis phil-davis commented Apr 27, 2021 •
edited
Loading

Description

This reverts commit 26ee19d.

Somehow that commit 26ee19d got onto master branch without the normal PR and CI process. It needs to be revert to make CI green again.

Related Issue

How Has This Been Tested?

CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@phil-davis phil-davis self-assigned this Apr 27, 2021
@phil-davis phil-davis requested a review from refs April 27, 2021 13:03
@phil-davis phil-davis mentioned this pull request Apr 27, 2021
Closed
@refs
Copy link
Member

refs commented Apr 27, 2021

It is really bizarre. 26ee19d got pushed to master, not force pushed at all, and I have no clue how. It was definitely my machine 🤔

@phil-davis phil-davis mentioned this pull request Apr 27, 2021
Closed
@phil-davis
Copy link
Contributor Author

It is really bizarre. 26ee19d got pushed to master, not force pushed at all, and I have no clue how. It was definitely my machine thinking

You must have some super-admin privs to the repo, that override branch protection.

@refs
Copy link
Member

refs commented Apr 27, 2021

I am Admin, however I tried pushing something to master and it blocked me 🤷

@phil-davis phil-davis mentioned this pull request Apr 27, 2021
Merged
5 tasks
@refs
Copy link
Member

refs commented Apr 27, 2021

@phil-davis
grafik

The culprit... I'll check that box :)

@refs
Copy link
Member

refs commented Apr 27, 2021

having a look at my git reflog I might have been drunk:

grafik

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@phil-davis phil-davis merged commit e436ecc into master Apr 27, 2021
@delete-merged-branch delete-merged-branch bot deleted the revert-expected-failures-change branch April 27, 2021 14:20
ownclouders pushed a commit that referenced this pull request Apr 27, 2021
@phil-davis
commit e436ecc
da2fb81 
Merge: 26ee19d fd4053f
Author: Phil Davis <phil@jankaritech.com>
Date:   Tue Apr 27 20:05:05 2021 +0545

    Merge pull request #1973 from owncloud/revert-expected-failures-change

    [tests-only] Revert "adjust expected failures for ocis"
@C0rby C0rby mentioned this pull request Apr 27, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@refs refs refs approved these changes

Assignees

@phil-davis phil-davis

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[QA] unexpected test failure
2 participants
@phil-davis @refs