reenable metrics for the deployment examples #2811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💥 Acceptance test Core-API-Tests-ocis-storage-7 failed. Further test are cancelled... |
wkloucek
force-pushed
the
reenable-metrics-deployment-examples
branch
from
094fcda
to
a601a2f
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
kobergj
approved these changes
Nov 24, 2021
delete-merged-branch
bot
deleted the
reenable-metrics-deployment-examples
branch
wkloucek
added a commit
that referenced
this pull request
Nov 24, 2021
9 tasks
ownclouders
pushed a commit
that referenced
this pull request
Nov 24, 2021
This was referenced Nov 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Metrics couldn't be collected since #2612 because the debug endpoints are only exposed on localhost. Therefore we need to actively expose them again for our docker setups if metric collection is used.
On the way some default config examples have been fixed regarding the debug address.
Also the
APP_PROVIDER_BASIC_*environment variables have been extended byAPP_PROVIDER_*variables, since the_BASIC_part is a copy and paste error. (These will be depreciated in #2812)Related Issue