Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[deployment examples] rename app provider environment variables #6055

Merged
merged 1 commit into from
Nov 24, 2021

Conversation

wkloucek
Copy link
Contributor

@wkloucek wkloucek commented Nov 24, 2021

Description

This PR switches to the new configuration environment variable for the app provider

Related Issue

Motivation and Context

Make the app provider in the deployment example work after owncloud/ocis#2812

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

@update-docs
Copy link

update-docs bot commented Nov 24, 2021

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@wkloucek wkloucek self-assigned this Nov 24, 2021
@wkloucek wkloucek marked this pull request as ready for review November 24, 2021 14:18
Copy link
Contributor

@pascalwengerter pascalwengerter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for taking care!

@wkloucek wkloucek merged commit 22775d3 into master Nov 24, 2021
@delete-merged-branch delete-merged-branch bot deleted the deployment-example-rename-app-provider-env branch November 24, 2021 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants