Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only][full-ci]Add tests removed by core 40276 #4371

Merged
merged 1 commit into from
Sep 5, 2022
Merged

[tests-only][full-ci]Add tests removed by core 40276 #4371

merged 1 commit into from
Sep 5, 2022

Conversation

SwikritiT
Copy link
Contributor

@SwikritiT SwikritiT commented Aug 10, 2022 •
edited
Loading

Description

Related Issue

Motivation and Context

How Has This Been Tested?

  • 🤖

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@SwikritiT SwikritiT mentioned this pull request Aug 10, 2022
Closed
2 tasks
@SwikritiT SwikritiT self-assigned this Aug 10, 2022
@SwikritiT SwikritiT mentioned this pull request Aug 10, 2022
Merged
11 tasks
@SwikritiT SwikritiT force-pushed the add-tests-removed-by-core-40276 branch 3 times, most recently from 897cb96 to 7e983da Compare August 12, 2022 10:28
@SwikritiT SwikritiT marked this pull request as ready for review August 12, 2022 10:29
@SwikritiT SwikritiT marked this pull request as draft August 12, 2022 10:29
@SwikritiT SwikritiT marked this pull request as ready for review August 12, 2022 11:17
@SwikritiT SwikritiT force-pushed the add-tests-removed-by-core-40276 branch from 7e983da to 185e658 Compare August 15, 2022 03:41
SagarGi
SagarGi reviewed Aug 15, 2022
View reviewed changes
Copy link
Member

@SagarGi SagarGi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍 let the CI be green.

@SwikritiT SwikritiT mentioned this pull request Aug 22, 2022
Closed
@SwikritiT SwikritiT force-pushed the add-tests-removed-by-core-40276 branch from 5867fea to ee38488 Compare August 22, 2022 17:59
@SwikritiT SwikritiT force-pushed the add-tests-removed-by-core-40276 branch from ee38488 to f4a78c8 Compare August 23, 2022 08:57
@SwikritiT SwikritiT force-pushed the add-tests-removed-by-core-40276 branch from 1d47213 to f3ea3ce Compare August 25, 2022 07:18
saw-jan
saw-jan reviewed Aug 26, 2022
View reviewed changes
Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SwikritiT SwikritiT force-pushed the add-tests-removed-by-core-40276 branch from f3ea3ce to 800a139 Compare August 29, 2022 04:27
kiranparajuli589
kiranparajuli589 reviewed Aug 29, 2022
View reviewed changes
Copy link
Contributor

@kiranparajuli589 kiranparajuli589 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@SwikritiT SwikritiT force-pushed the add-tests-removed-by-core-40276 branch from 800a139 to 123415c Compare August 29, 2022 05:40
@SwikritiT SwikritiT force-pushed the add-tests-removed-by-core-40276 branch from 123415c to f274752 Compare August 31, 2022 10:45
@SwikritiT SwikritiT force-pushed the add-tests-removed-by-core-40276 branch from f274752 to 7a9e116 Compare September 2, 2022 03:50
@SwikritiT SwikritiT requested review from individual-it and removed request for sushmita56 September 2, 2022 08:54
@phil-davis
Copy link
Contributor

@SwikritiT conflicts in SpaceContext - needs a rebase.

@SwikritiT SwikritiT force-pushed the add-tests-removed-by-core-40276 branch 3 times, most recently from 5ce828b to 15b4a82 Compare September 5, 2022 10:19
@SwikritiT
Copy link
Contributor Author

@SwikritiT conflicts in SpaceContext - needs a rebase.

Done!

@phil-davis phil-davis force-pushed the add-tests-removed-by-core-40276 branch from 15b4a82 to c50839e Compare September 5, 2022 10:49
@phil-davis
Copy link
Contributor

Somehow drone did not start properly, so I force-pushed again. It seems to be running now:
https://drone.owncloud.com/owncloud/ocis/15200

@phil-davis
Copy link
Contributor

I will rebase again - some TUS changes just got merged to master.

@phil-davis phil-davis force-pushed the add-tests-removed-by-core-40276 branch from c50839e to 70ed979 Compare September 5, 2022 11:37
@sonarcloud
Copy link

sonarcloud bot commented Sep 5, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@phil-davis phil-davis merged commit 68e5830 into master Sep 5, 2022
@delete-merged-branch delete-merged-branch bot deleted the add-tests-removed-by-core-40276 branch September 5, 2022 12:41
ownclouders pushed a commit that referenced this pull request Sep 5, 2022
@phil-davis
commit 68e5830
f4a500e 
Merge: 6f9afa8 70ed979
Author: Phil Davis <phil@jankaritech.com>
Date:   Mon Sep 5 18:26:30 2022 +0545

    Merge pull request #4371 from owncloud/add-tests-removed-by-core-40276

    [tests-only][full-ci]Add tests removed by core 40276
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saw-jan saw-jan saw-jan left review comments

@SagarGi SagarGi SagarGi left review comments

@kiranparajuli589 kiranparajuli589 kiranparajuli589 left review comments

@phil-davis phil-davis phil-davis approved these changes

@amrita-shrestha amrita-shrestha Awaiting requested review from amrita-shrestha

@individual-it individual-it Awaiting requested review from individual-it

Assignees

@SwikritiT SwikritiT

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@SwikritiT @phil-davis @individual-it @kiranparajuli589 @SagarGi @saw-jan @amrita-shrestha