Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only] [full-ci] ApiTest. after each test users delete their personal space #4433

Merged
merged 3 commits into from
Aug 23, 2022
Merged

[tests-only] [full-ci] ApiTest. after each test users delete their personal space #4433

merged 3 commits into from
Aug 23, 2022

Conversation

ScharfViktor
Copy link
Contributor

@ScharfViktor ScharfViktor commented Aug 22, 2022 •
edited by phil-davis
Loading

  • added the ability to delete personal space after each test
  • deleted failed test from expected failures

Part of issue #4390

@ScharfViktor ScharfViktor mentioned this pull request Aug 22, 2022
Closed
@owncloud owncloud deleted a comment from update-docs bot Aug 23, 2022
@phil-davis phil-davis changed the title [test-only] ApiTest. after each test users delete their personal space [tests-only] ApiTest. after each test users delete their personal space Aug 23, 2022
@phil-davis phil-davis changed the title [tests-only] ApiTest. after each test users delete their personal space [tests-only] [full-ci] ApiTest. after each test users delete their personal space Aug 23, 2022
SwikritiT
SwikritiT approved these changes Aug 23, 2022
View reviewed changes
Copy link
Contributor

@SwikritiT SwikritiT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@phil-davis phil-davis mentioned this pull request Aug 23, 2022
Merged
9 tasks
individual-it
individual-it reviewed Aug 23, 2022
View reviewed changes
Copy link
Member

@individual-it individual-it left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just minor ideas

tests/acceptance/features/bootstrap/SpacesContext.php Outdated Show resolved Hide resolved
tests/acceptance/features/bootstrap/SpacesContext.php Outdated Show resolved Hide resolved
@SwikritiT SwikritiT mentioned this pull request Aug 23, 2022
Merged
9 tasks
@sonarcloud
Copy link

sonarcloud bot commented Aug 23, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@ScharfViktor
Copy link
Contributor Author

https://drone.owncloud.com/owncloud/ocis/14804

CI is green but wait docker arm and docker arm64. do you have any idea why this is happening?

@phil-davis
Copy link
Contributor

CI is stuck because the drone server in the Hetzner cloud cannot create any ARM agents to run the very last 2 pipelines.

@ScharfViktor
Copy link
Contributor Author

CI is stuck because the drone server in the Hetzner cloud cannot create any ARM agents to run the very last 2 pipelines.

asked the admins to look into it

@butonic butonic merged commit cb2822b into master Aug 23, 2022
@delete-merged-branch delete-merged-branch bot deleted the userDeletesHisPersonalSpace branch August 23, 2022 08:42
ownclouders pushed a commit that referenced this pull request Aug 23, 2022
@ScharfViktor
commit cb2822b
a025ecc 
Author: Viktor Scharf <scharf.vi@gmail.com>
Date:   Tue Aug 23 10:42:27 2022 +0200

    [tests-only] [full-ci] ApiTest. after each test users delete their personal space (#4433)

    * after each test users delete their personal space

    * Simplify deleteAllPersonalSpaces

    * Simplify deleteAllPersonalSpaces()

    Co-authored-by: Phil Davis <phil@jankaritech.com>
@phil-davis phil-davis mentioned this pull request Aug 25, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phil-davis phil-davis phil-davis approved these changes

@SwikritiT SwikritiT SwikritiT approved these changes

@individual-it individual-it individual-it approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ScharfViktor @phil-davis @individual-it @SwikritiT @butonic