[tests-only][full-ci] copy test dependencies from ownCloud/core (stable-2.0) #5306

phil-davis · 2022-12-29T06:55:00Z

Description

Copy test infrastructure from the oC/core repository

This is a port of #5280 to the stable-2.0 branch. See discussion in that PR and in the issue for explanation of what is being done.

The API tests no longer use anything from owncloud/core

Related Issue

#5094

How Has This Been Tested?

CI

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
Technical debt
Tests only (no source changes)

Checklist:

Code changes
Unit tests added
Acceptance tests added
Documentation ticket raised:

phil-davis · 2022-12-30T06:30:45Z

Note: we will leave this here until next week. Also leave #5280
I will switch it to draft for now.

I would like to double-check that all other test changes have been ported the same into both master and stable-2.0 branches, and get any recent test code changes that have happened in core. And then merge when we are happy that everything is "in sync".

saw-jan · 2023-01-03T08:02:58Z

Todos:

update expected failure list

Signed-off-by: Kiran Parajuli <kiranparajuli589@gmail.com>

…ests run Signed-off-by: Kiran Parajuli <kiranparajuli589@gmail.com>

Signed-off-by: Kiran Parajuli <kiranparajuli589@gmail.com>

remove unnecessary script from run.sh

remove oc10 specific test suites provide behat config with make command fix typo add missing helpers

saw-jan · 2023-01-04T04:02:17Z

Changes to notice:

feature suites are prefixed core and copied to the tests/acceptance/features folder (e.g. ApiMain -> coreApiMain)
separate behat config for copied core tests (tests/acceptance/config/behat-core.yml)
core API tests run in parts in CI

These structures can be discussed.

CC @kiranparajuli589 @phil-davis @individual-it

phil-davis

Looking good to me.

phil-davis · 2023-01-04T08:04:17Z

tests/acceptance/run.sh

+if [ "${TEST_OCIS}" != "true" ] && [ "${TEST_REVA}" != "true" ]
+then
+	# We are testing on an ownCloud core server.
+	# Tell the tests to wait 1 second between each upload/delete action
+	# to avoid problems with actions that depend on timestamps in seconds.
+	export UPLOAD_DELETE_WAIT_TIME=1
+fi


This bit of code might now be useless here in ocis.
But maybe it will be needed (and the if condition modified a bit) if we enable the parallel deployment tests.
So we can leave it here for now.

individual-it

I think the structure is fine for now.
From the .drone.star file we should be to delete the functions

cacheCoreReposForTesting
cloneCoreRepos

phil-davis · 2023-01-04T08:19:58Z

I think that these cleanup things can be done in a next PR after we merge this one. For future comparisons, it is probably cleaner to merge all the feature files as direct copies from core. Then delete unneeded stuff separately. That way the deletions will appear in diff listings that can be easily seen.

remove any scenarios that are tagged skipOnOcis

The core API tests run with these filter tags:

~@skipOnGraph&&~@skipOnOcis&&~@notToImplementOnOCIS&&~@toImplementOnOCIS&&~comments-app-required&&~@federation-app-required&&~@notifications-app-required&&~systemtags-app-required&&~@local_storage&&~@skipOnOcis-OCIS-Storage&&~@caldav&&~@carddav&&@api&&~@skip

look through the filter tags and sort out which ones we still care about.
remove scenarios for any tags that we know are never gong to be relevant to ocis or reva
cut-down the filter-tags list

phil-davis · 2023-01-04T08:21:34Z

The core-api CI pipelines look good - they run suites and scenarios without ever fetching anything from the owncloud/core repo.

saw-jan · 2023-01-04T08:27:51Z

This PR is ready from my side.

phil-davis · 2023-01-04T08:30:53Z

Note: these test suites have not been copied from core:
apiComments - comments will not work like that in ocis anyway, if and when implemented
apiFederation* - "core federation" is an oC10 thing
apiProvisioning-v* - we don't use the provisioning API any more
apiProvisioningGroups-v* - we don't use the provisioning API any more
apiShareToRoot - these are for shares received directly in the sharees root folder. That does not happen in ocis
apiSharingNotifications* - they are specific to the notifications app behavior in oC10
apiTags - that is a specific implementation of tags for oC10

That looks good to me.

phil-davis · 2023-01-04T08:38:43Z

I think the structure is fine for now. From the .drone.star file we should be to delete the functions
* cacheCoreReposForTesting

* cloneCoreRepos

Those are now only used by parallelDeployAcceptancePipeline - we could remove them now, or we leave them as-is and sort out the needed refactoring when the parallelApiTests are enabled again "some day".

individual-it · 2023-01-04T08:44:55Z

as discussed in the standup meeting, parallel deployment tests are not prio now, so lets delete cacheCoreReposForTesting & cloneCoreRepo now and the parallel deployment tests in an other PR as its dead code. We can bring it back when its needed.

phil-davis · 2023-01-04T08:46:58Z

as discussed in the standup meeting, parallel deployment tests are not prio now, so lets delete cacheCoreReposForTesting & cloneCoreRepo now and the parallel deployment tests in an other PR as its dead code. We can bring it back when its needed.

I will push another commit to cleanup.

sonarqubecloud · 2023-01-04T09:29:26Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

phil-davis · 2023-01-04T10:05:39Z

@individual-it @micbar this is ready for review. We need 2 approvals to merge. I have reviewed the code that was done by @kiranparajuli589 and @saw-jan but I cannot approve because I created the PR.

There are many thousands of lines because lots of code and feature files have been copied from owncloud/core - I don't expect all the lines to be individually reviewed!

ScharfViktor · 2023-01-04T12:49:58Z

looks cool
questions: should we clean up some of the moved tests? for example: tagsTests or tets with @skipOnOcis tag
Or will we clean it up later in another PR?

phil-davis · 2023-01-04T12:52:04Z

Or will we clean it up later in another PR?

I suggest that we clean up in another PR - see my comment #5306 (comment)

ScharfViktor · 2023-01-04T12:58:33Z

yes, sorry. I saw
then in order not to lose what i found. need remove:

TagsContext
TagsHelper
TranslationHelper
translation.feature

Merge: 13a7065 b1c0ea6 Author: Phil Davis <phil@jankaritech.com> Date: Thu Jan 5 09:22:18 2023 +0545 Merge pull request #5306 from owncloud/remove-ownCloud-core-test-dependency-stable [tests-only][full-ci] copy test dependencies from ownCloud/core (stable-2.0)

phil-davis added the QA:team label Dec 29, 2022

phil-davis self-assigned this Dec 29, 2022

phil-davis requested review from wkloucek, micbar and individual-it as code owners December 29, 2022 06:55

phil-davis mentioned this pull request Dec 29, 2022

[tests-only][full-ci] copy test dependencies from the ownCloud/core #5280

Merged

9 tasks

phil-davis force-pushed the remove-ownCloud-core-test-dependency-stable branch from 789ea02 to fb42d15 Compare December 29, 2022 08:18

phil-davis marked this pull request as draft December 30, 2022 06:30

saw-jan force-pushed the remove-ownCloud-core-test-dependency-stable branch 3 times, most recently from e5076de to 06d7c51 Compare January 3, 2023 06:48

saw-jan self-assigned this Jan 3, 2023

saw-jan force-pushed the remove-ownCloud-core-test-dependency-stable branch 8 times, most recently from 3fb009d to a2dfecf Compare January 3, 2023 11:43

kiranparajuli589 and others added 8 commits January 4, 2023 09:28

Copied acceptance tests infrastructures from oC/core

d4d71a6

Signed-off-by: Kiran Parajuli <kiranparajuli589@gmail.com>

Only define bootstrap constants for local api tests, skip for other t…

18ba8cb

…ests run Signed-off-by: Kiran Parajuli <kiranparajuli589@gmail.com>

Typo fixes on comments with reverting substr related changes

67db2f1

Signed-off-by: Kiran Parajuli <kiranparajuli589@gmail.com>

copy feature files from core

3030c2b

use separate behat config for core tests

60ee3c8

remove unnecessary suite config

824545f

remove unnecessary script from run.sh

fix: get test suites for core api tests

de90cfd

remove oc10 specific test suites provide behat config with make command fix typo add missing helpers

update expected failure list

c3a3653

saw-jan force-pushed the remove-ownCloud-core-test-dependency-stable branch from ce314a1 to 998da12 Compare January 4, 2023 03:54

phil-davis commented Jan 4, 2023

View reviewed changes

individual-it reviewed Jan 4, 2023

View reviewed changes

phil-davis marked this pull request as ready for review January 4, 2023 08:39

phil-davis requested a review from individual-it January 4, 2023 08:39

phil-davis added 2 commits January 4, 2023 15:04

Remove unused core oC10 and parallel deploy drone starlark code

b227b5d

Remove unused CORE_COMMITID from .drone.env

b1c0ea6

saw-jan mentioned this pull request Jan 4, 2023

[QA] Bump commit id [Jan 02 - Jan 13] owncloud/QA#792

Closed

13 tasks

individual-it approved these changes Jan 4, 2023

View reviewed changes

phil-davis requested a review from ScharfViktor January 4, 2023 11:14

ScharfViktor approved these changes Jan 4, 2023

View reviewed changes

phil-davis merged commit bf95981 into stable-2.0 Jan 5, 2023

delete-merged-branch bot deleted the remove-ownCloud-core-test-dependency-stable branch January 5, 2023 03:37

This was referenced Jan 5, 2023

Api tests scenario related to share permission needs changes #5249

Closed

Cleanup core API test codes from oCIS #5337

Closed

phil-davis mentioned this pull request Jan 12, 2023

[QA] Cleanup API acceptance test code owncloud/core#40572

Open

11 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[tests-only][full-ci] copy test dependencies from ownCloud/core (stable-2.0) #5306

[tests-only][full-ci] copy test dependencies from ownCloud/core (stable-2.0) #5306

phil-davis commented Dec 29, 2022 •

edited

Loading

phil-davis commented Dec 30, 2022

saw-jan commented Jan 3, 2023 •

edited

Loading

saw-jan commented Jan 4, 2023 •

edited

Loading

phil-davis left a comment

phil-davis Jan 4, 2023

individual-it left a comment

phil-davis commented Jan 4, 2023

phil-davis commented Jan 4, 2023

saw-jan commented Jan 4, 2023

phil-davis commented Jan 4, 2023

phil-davis commented Jan 4, 2023

individual-it commented Jan 4, 2023

phil-davis commented Jan 4, 2023

sonarqubecloud bot commented Jan 4, 2023

phil-davis commented Jan 4, 2023

ScharfViktor commented Jan 4, 2023

phil-davis commented Jan 4, 2023

ScharfViktor commented Jan 4, 2023 •

edited

Loading

[tests-only][full-ci] copy test dependencies from ownCloud/core (stable-2.0) #5306

[tests-only][full-ci] copy test dependencies from ownCloud/core (stable-2.0) #5306

Conversation

phil-davis commented Dec 29, 2022 • edited Loading

Description

Related Issue

How Has This Been Tested?

Types of changes

Checklist:

phil-davis commented Dec 30, 2022

saw-jan commented Jan 3, 2023 • edited Loading

saw-jan commented Jan 4, 2023 • edited Loading

phil-davis left a comment

Choose a reason for hiding this comment

phil-davis Jan 4, 2023

Choose a reason for hiding this comment

individual-it left a comment

Choose a reason for hiding this comment

phil-davis commented Jan 4, 2023

phil-davis commented Jan 4, 2023

saw-jan commented Jan 4, 2023

phil-davis commented Jan 4, 2023

phil-davis commented Jan 4, 2023

individual-it commented Jan 4, 2023

phil-davis commented Jan 4, 2023

sonarqubecloud bot commented Jan 4, 2023

phil-davis commented Jan 4, 2023

ScharfViktor commented Jan 4, 2023

phil-davis commented Jan 4, 2023

ScharfViktor commented Jan 4, 2023 • edited Loading

phil-davis commented Dec 29, 2022 •

edited

Loading

saw-jan commented Jan 3, 2023 •

edited

Loading

saw-jan commented Jan 4, 2023 •

edited

Loading

ScharfViktor commented Jan 4, 2023 •

edited

Loading