Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup core API test codes from oCIS #5337

Closed
47 of 57 tasks
saw-jan opened this issue Jan 5, 2023 · 5 comments
Closed
47 of 57 tasks

Cleanup core API test codes from oCIS #5337

saw-jan opened this issue Jan 5, 2023 · 5 comments
Assignees
Labels

Comments

@saw-jan
Copy link
Member

saw-jan commented Jan 5, 2023

Copying core API tests completed with PRs #5280 and #5306

Features and test codes need some cleanup:

**Point to be noted:** We skipped the space Dav version-related tests in Reva so we implement @personalSpace
Discussed in: https://github.com/cs3org/reva/pull/2451#issuecomment-1016227463` so we have to look at whether Reva supports space dav or not ❓ 
@saw-jan saw-jan added the QA:team label Jan 5, 2023
@grgprarup grgprarup self-assigned this Feb 1, 2023
@amrita-shrestha
Copy link
Contributor

amrita-shrestha commented May 8, 2023

we have issue tags like @issue-product- , need to clarify if we still need them , and if not maybe we can remove them

@SwikritiT product repo was used a long time ago for discussions/issues about features and how they should be implemented. It is not used anymore. but I think we can keep @issue-product- for issue reference

@phil-davis What should we do ❓

@phil-davis
Copy link
Contributor

What should we do?

Check that the "product" issues are still correct - most of them should have been moved to the ocis repo. And update them to have the current ocis issue number. That will make it easy for developers to find the issue - they will not have to realize about the history of the "product" repo.

If there are ocis issues still open in the product repo, then we should review them (write updated information about the issue) and if still relevant, moved them to the ocis repo. Ping me if you cannot move them yourself.

@saw-jan
Copy link
Member Author

saw-jan commented Jun 5, 2024

We can do a final check and then close this one.

CC @amrita-shrestha @nirajacharya2

@saw-jan
Copy link
Member Author

saw-jan commented Jul 9, 2024

@amrita-shrestha let's close this one if everything in done

@nabim777
Copy link
Member

nabim777 commented Jul 9, 2024

All task has been done. so, closing this issue

@nabim777 nabim777 closed this as completed Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants