Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test-only] ApiTest. create tag #5391

Merged
merged 3 commits into from
Jan 17, 2023
Merged

[test-only] ApiTest. create tag #5391

merged 3 commits into from
Jan 17, 2023

Conversation

ScharfViktor
Copy link
Contributor

@ScharfViktor ScharfViktor commented Jan 12, 2023

@update-docs
Copy link

update-docs bot commented Jan 12, 2023

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@ownclouders
Copy link
Contributor

ownclouders commented Jan 12, 2023

💥 Acceptance test settingsUITests failed. Further test are cancelled...

@ScharfViktor ScharfViktor changed the title [test-only] ApiTest. create tag [full-ci][test-only] ApiTest. create tag Jan 13, 2023
@ScharfViktor
Copy link
Contributor Author

deleted tests from search.feature

and closed bug #3092

Scenario: search for entry by tags using REPORT method
    Given user "Alice" has created a "normal" tag with name "JustARegularTag1"
    And user "Alice" has created a "normal" tag with name "JustARegularTag2"
    And user "Alice" has added tag "JustARegularTag1" to folder "फनी näme"
    And user "Alice" has added tag "JustARegularTag1" to file "upload.txt"
    And user "Alice" has added tag "JustARegularTag2" to file "upload.txt"
    When user "Alice" searches for resources tagged with tag "JustARegularTag1" using the webDAV API
    Then the HTTP status code should be "207"
    And the search result by tags for user "Alice" should contain these entries:
      | फनी näme   |
      | upload.txt |
    When user "Alice" searches for resources tagged with tag "JustARegularTag2" using the webDAV API
    Then the HTTP status code should be "207"
    And the search result by tags for user "Alice" should contain these entries:
      | upload.txt |


  Scenario: share a tagged resource to another internal user and sharee searches for tag using REPORT method
    Given user "Brian" has been created with default attributes and without skeleton files
    And user "Alice" has created a "normal" tag with name "JustARegularTag1"
    And user "Alice" has created a "normal" tag with name "JustARegularTag2"
    And user "Alice" has added tag "JustARegularTag1" to folder "फनी näme"
    And user "Alice" has added tag "JustARegularTag1" to file "upload.txt"
    And user "Alice" has added tag "JustARegularTag2" to file "upload.txt"
    And user "Alice" has shared file "फनी näme" with user "Brian"
    And user "Alice" has shared file "upload.txt" with user "Brian"
    When user "Brian" searches for resources tagged with tag "JustARegularTag1" using the webDAV API
    Then the HTTP status code should be "207"
    And the search result by tags for user "Brian" should contain these entries:
      | फनी näme   |
      | upload.txt |
    When user "Brian" searches for resources tagged with tag "JustARegularTag2" using the webDAV API
    Then the HTTP status code should be "207"
    And the search result by tags for user "Brian" should contain these entries:
      | upload.txt |
    When user "Brian" searches for resources tagged with all of the following tags using the webDAV API
      | JustARegularTag1 |
      | JustARegularTag2 |
    Then the HTTP status code should be "207"
    And as user "Brian" the response should contain file "upload.txt"
    And as user "Brian" the response should not contain file "फनी näme"


  Scenario: search for entries across various folders by tags using REPORT method
    Given user "Alice" has created folder "/just-a-folder/inner-folder"
    And user "Alice" has uploaded file with content "inner file" to "/just-a-folder/inner-folder/upload.txt"
    And user "Alice" has created a "normal" tag with name "JustARegularTag1"
    And user "Alice" has created a "normal" tag with name "JustARegularTag2"
    And user "Alice" has added tag "JustARegularTag1" to folder "/just-a-folder/upload.txt"
    And user "Alice" has added tag "JustARegularTag1" to file "/फनी näme/upload.txt"
    And user "Alice" has added tag "JustARegularTag1" to file "/just-a-folder/inner-folder/upload.txt"
    And user "Alice" has added tag "JustARegularTag2" to file "/upload😀 😁/upload,1.txt"
    And user "Alice" has added tag "JustARegularTag2" to file "/upload.txt"
    When user "Alice" searches for resources tagged with tag "JustARegularTag1" using the webDAV API
    Then the HTTP status code should be "207"
    And the search result by tags for user "Alice" should contain these entries:
      | upload.txt |
      | upload.txt |
      | upload.txt |
    When user "Alice" searches for resources tagged with tag "JustARegularTag2" using the webDAV API
    Then the HTTP status code should be "207"
    And the search result by tags for user "Alice" should contain these entries:
      | upload,1.txt |
      | upload.txt   |

@ScharfViktor ScharfViktor changed the title [full-ci][test-only] ApiTest. create tag [test-only] ApiTest. create tag Jan 13, 2023
Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks goof 👍

tests/TestHelpers/GraphHelper.php Outdated Show resolved Hide resolved
tests/acceptance/features/apiSpaces/tag.feature Outdated Show resolved Hide resolved
tests/acceptance/features/bootstrap/TagContext.php Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Jan 17, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@ScharfViktor ScharfViktor merged commit 7c94527 into master Jan 17, 2023
@delete-merged-branch delete-merged-branch bot deleted the createTagTest branch January 17, 2023 11:42
ownclouders pushed a commit that referenced this pull request Jan 17, 2023
Author: Viktor Scharf <scharf.vi@gmail.com>
Date:   Tue Jan 17 12:41:56 2023 +0100

    [test-only] ApiTest. create tag (#5391)

    * create tag

    * split method

    * fix after review
ownclouders pushed a commit that referenced this pull request Jan 18, 2023
Author: Viktor Scharf <scharf.vi@gmail.com>
Date:   Tue Jan 17 12:41:56 2023 +0100

    [test-only] ApiTest. create tag (#5391)

    * create tag

    * split method

    * fix after review
@ScharfViktor ScharfViktor mentioned this pull request Jan 18, 2023
24 tasks
saw-jan pushed a commit that referenced this pull request Feb 28, 2023
* create tag

* split method

* fix after review
grgprarup pushed a commit that referenced this pull request Mar 2, 2023
* create tag

* split method

* fix after review
grgprarup pushed a commit that referenced this pull request Mar 3, 2023
* create tag

* split method

* fix after review
phil-davis pushed a commit that referenced this pull request Mar 6, 2023
* create tag

* split method

* fix after review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants