Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only][full-ci] removed steps related to share api occ commands #6096

Merged
merged 3 commits into from
May 10, 2023
Merged

[tests-only][full-ci] removed steps related to share api occ commands #6096

merged 3 commits into from
May 10, 2023

Conversation

PrajwolAmatya
Copy link
Contributor

@PrajwolAmatya PrajwolAmatya commented Apr 20, 2023 •
edited
Loading

Description

This PR removes the steps related to share api with the following occ commands:

  • shareapi_auto_accept_share
  • shareapi_allow_public_upload
  • shareapi_allow_resharing
  • shareapi_only_share_with_group_members
  • shareapi_share_dialog_user_enumeration_group_members
  • shareapi_default_expire_date_user_share
  • shareapi_enforce_expire_date_user_share
  • shareapi_expire_after_n_days_user_share

Related Issue

Related to issue: #4623

Motivation and Context

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@PrajwolAmatya PrajwolAmatya self-assigned this Apr 20, 2023
@PrajwolAmatya PrajwolAmatya mentioned this pull request Apr 20, 2023
Closed
57 tasks
@PrajwolAmatya PrajwolAmatya force-pushed the remove-test-related-to-public-link-sharing branch 4 times, most recently from b75505c to b668274 Compare April 21, 2023 09:44
@PrajwolAmatya PrajwolAmatya mentioned this pull request Apr 21, 2023
Closed
@PrajwolAmatya PrajwolAmatya marked this pull request as ready for review April 21, 2023 11:01
SagarGi
SagarGi reviewed Apr 26, 2023
View reviewed changes
Copy link
Member

@SagarGi SagarGi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can get rid of all this scenarios and also from the expected to failure.

@PrajwolAmatya PrajwolAmatya force-pushed the remove-test-related-to-public-link-sharing branch 7 times, most recently from 34ecdec to 20f994b Compare May 3, 2023 03:20
@PrajwolAmatya PrajwolAmatya force-pushed the remove-test-related-to-public-link-sharing branch 2 times, most recently from 2d13275 to 4a947ba Compare May 4, 2023 03:35
@PrajwolAmatya PrajwolAmatya force-pushed the remove-test-related-to-public-link-sharing branch from 4a947ba to d6aa0ad Compare May 4, 2023 05:52
@PrajwolAmatya PrajwolAmatya force-pushed the remove-test-related-to-public-link-sharing branch from d6aa0ad to a2b3f4a Compare May 4, 2023 10:55
@PrajwolAmatya PrajwolAmatya force-pushed the remove-test-related-to-public-link-sharing branch from a2b3f4a to f1b91bf Compare May 5, 2023 07:05
@PrajwolAmatya PrajwolAmatya force-pushed the remove-test-related-to-public-link-sharing branch 5 times, most recently from 639ac04 to c9aeff1 Compare May 8, 2023 10:39
@PrajwolAmatya PrajwolAmatya force-pushed the remove-test-related-to-public-link-sharing branch from c9aeff1 to 827463e Compare May 9, 2023 03:27
saw-jan
saw-jan reviewed May 9, 2023
View reviewed changes
Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PrajwolAmatya PrajwolAmatya force-pushed the remove-test-related-to-public-link-sharing branch from 827463e to 2163a48 Compare May 9, 2023 10:42
@sonarcloud
Copy link

sonarcloud bot commented May 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

phil-davis
phil-davis approved these changes May 10, 2023
View reviewed changes
Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@PrajwolAmatya @saw-jan @SwikritiT if there is nothing more to do here, please merge.

@saw-jan saw-jan merged commit 1788406 into master May 10, 2023
@delete-merged-branch delete-merged-branch bot deleted the remove-test-related-to-public-link-sharing branch May 10, 2023 04:28
ownclouders pushed a commit that referenced this pull request May 10, 2023
@PrajwolAmatya
[tests-only][full-ci] removed steps related to share api occ commands (…
70219d5 
…#6096)

* removed steps related to occ commands

* removed scenarios from expected failures

* fixed lines in exp failure
fschade pushed a commit that referenced this pull request Jul 10, 2023
@PrajwolAmatya @fschade
[tests-only][full-ci] removed steps related to share api occ commands (…
3b46447 
…#6096)

* removed steps related to occ commands

* removed scenarios from expected failures

* fixed lines in exp failure
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phil-davis phil-davis phil-davis approved these changes

@SwikritiT SwikritiT Awaiting requested review from SwikritiT

@SagarGi SagarGi Awaiting requested review from SagarGi

@amrita-shrestha amrita-shrestha Awaiting requested review from amrita-shrestha

@saw-jan saw-jan Awaiting requested review from saw-jan

@grgprarup grgprarup Awaiting requested review from grgprarup

Assignees

@PrajwolAmatya PrajwolAmatya

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@PrajwolAmatya @phil-davis @grgprarup @SagarGi @saw-jan @amrita-shrestha