Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only][full-ci] removed steps related to share api occ commands #6096

Merged
merged 3 commits into from
May 10, 2023
Merged

[tests-only][full-ci] removed steps related to share api occ commands #6096

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d5b6e07
removed steps related to occ commands
PrajwolAmatya Apr 20, 2023
17c4fa1
removed scenarios from expected failures
PrajwolAmatya Apr 27, 2023
2fbe134
fixed lines in exp failure
PrajwolAmatya May 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
72 changes: 18 additions & 54 deletions tests/acceptance/expected-failures-API-on-OCIS-storage.md
View file
Open in desktop

Large diffs are not rendered by default.

16 changes: 0 additions & 16 deletions tests/acceptance/features/bootstrap/AppConfigurationContext.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,22 +57,6 @@ public function adminSetsServerParameterToUsingAPI(
$this->modifyAppConfig($app, $parameter, $value);
}

/**
* @Given /^parameter "([^"]*)" of app "([^"]*)" has been set to ((?:'[^']*')|(?:"[^"]*"))$/
*
* @param string $parameter
* @param string $app
* @param string $value
*
* @return void
* @throws Exception
*/
public function serverParameterHasBeenSetTo(string $parameter, string $app, string $value):void {
// The capturing group of the regex always includes the quotes at each
// end of the captured string, so trim them.
return;
}

/**
* @Then the capabilities setting of :capabilitiesApp path :capabilitiesPath should be :expectedValue
* @Given the capabilities setting of :capabilitiesApp path :capabilitiesPath has been confirmed to be :expectedValue
Expand Down
3 changes: 1 addition & 2 deletions tests/acceptance/features/coreApiShareManagementToShares/acceptSharesToSharesFolder.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,7 @@ Feature: accept/decline shares coming from internal users to the Shares folder
So that I can keep my file system clean

Background:
Given parameter "shareapi_auto_accept_share" of app "core" has been set to "no"
And using OCS API version "1"
Given using OCS API version "1"
PrajwolAmatya marked this conversation as resolved.
Show resolved Hide resolved
And using new DAV path
And these users have been created with default attributes and without skeleton files:
| username |
Expand Down
20 changes: 8 additions & 12 deletions tests/acceptance/features/coreApiShareOperationsToShares2/shareAccessByID.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,8 +75,7 @@ Feature: share access by ID


Scenario Outline: accept a share using the invalid share Id
Given parameter "shareapi_auto_accept_share" of app "core" has been set to "yes"
And using OCS API version "<ocs_api_version>"
Given using OCS API version "<ocs_api_version>"
When user "Brian" accepts share with ID "<share_id>" using the sharing API
Then the OCS status code should be "404"
And the HTTP status code should be "<http_status_code>"
Expand All @@ -94,8 +93,7 @@ Feature: share access by ID


Scenario Outline: accept a share using empty share Id
PrajwolAmatya marked this conversation as resolved.
Show resolved Hide resolved
Given parameter "shareapi_auto_accept_share" of app "core" has been set to "yes"
And using OCS API version "<ocs_api_version>"
Given using OCS API version "<ocs_api_version>"
PrajwolAmatya marked this conversation as resolved.
Show resolved Hide resolved
When user "Brian" accepts share with ID "" using the sharing API
Then the OCS status code should be "<ocs_status_code>"
And the HTTP status code should be "<http_status_code>"
Expand All @@ -118,16 +116,15 @@ Feature: share access by ID
| /Shares/textfile0.txt |
And the sharing API should report to user "Brian" that these shares are in the declined state
| path |
| <declined_share_path> |
| /Shares/textfile0.txt |
Examples:
| ocs_api_version | ocs_status_code | declined_share_path |
| 1 | 100 | /Shares/textfile0.txt |
| 2 | 200 | /Shares/textfile0.txt |
| ocs_api_version | ocs_status_code |
| 1 | 100 |
| 2 | 200 |


Scenario Outline: decline a share using a invalid share Id
Given parameter "shareapi_auto_accept_share" of app "core" has been set to "yes"
And using OCS API version "<ocs_api_version>"
Given using OCS API version "<ocs_api_version>"
When user "Brian" declines share with ID "<share_id>" using the sharing API
Then the OCS status code should be "404"
And the HTTP status code should be "<http_status_code>"
Expand All @@ -145,8 +142,7 @@ Feature: share access by ID


Scenario Outline: decline a share using empty share Id
Given parameter "shareapi_auto_accept_share" of app "core" has been set to "yes"
And using OCS API version "<ocs_api_version>"
Given using OCS API version "<ocs_api_version>"
When user "Brian" declines share with ID "" using the sharing API
Then the OCS status code should be "<ocs_status_code>"
And the HTTP status code should be "<http_status_code>"
Expand Down
1 change: 0 additions & 1 deletion tests/acceptance/features/coreApiSharePublicLink1/createPublicLinkShare.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,7 +219,6 @@ Feature: create a public link share

Scenario Outline: creating a link share with no specified permissions defaults to read permissions when public upload is disabled globally and accessing using the public WebDAV API
Given using OCS API version "<ocs_api_version>"
And parameter "shareapi_allow_public_upload" of app "core" has been set to "no"
And user "Alice" has created folder "/afolder"
When user "Alice" creates a public link share using the sharing API with settings
| path | /afolder |
Expand Down
20 changes: 0 additions & 20 deletions tests/acceptance/features/coreApiSharePublicLink3/uploadToPublicLinkShare.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,26 +98,6 @@ Feature: upload to a public link share
When the public uploads file "test.txt" with content "test-file" using the new public WebDAV API
Then the HTTP status code should be "507"

@issue-1328
Scenario: Uploading file to a public shared folder does not work when allow public uploads has been disabled before sharing and again enabled after sharing the folder with public API
Given parameter "shareapi_allow_public_upload" of app "core" has been set to "no"
And user "Alice" has created a public link share with settings
| path | FOLDER |
And parameter "shareapi_allow_public_upload" of app "core" has been set to "yes"
When the public uploads file "test.txt" with content "test-file" using the new public WebDAV API
And the HTTP status code should be "403"

@issue-1328
Scenario: Uploading file to a public shared folder works when allow public uploads has been disabled and again enabled after sharing the folder with public API
Given user "Alice" has created a public link share with settings
| path | FOLDER |
| permissions | create |
And parameter "shareapi_allow_public_upload" of app "core" has been set to "no"
And parameter "shareapi_allow_public_upload" of app "core" has been set to "yes"
When the public uploads file "test.txt" with content "test-file" using the new public WebDAV API
Then the HTTP status code should be "201"
And the content of file "/FOLDER/test.txt" for user "Alice" should be "test-file"

@smokeTest
Scenario: Uploading to a public upload-write and no edit and no overwrite share with public API
Given user "Alice" has created a public link share with settings
Expand Down
1 change: 0 additions & 1 deletion tests/acceptance/features/coreApiShareReshareToShares2/reShareDisabled.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ Feature: resharing can be disabled

Scenario Outline: ordinary sharing is allowed when allow resharing has been disabled
Given using OCS API version "<ocs_api_version>"
And parameter "shareapi_allow_resharing" of app "core" has been set to "no"
When user "Alice" shares file "/textfile0.txt" with user "Brian" with permissions "share,update,read" using the sharing API
Then the OCS status code should be "<ocs_status_code>"
And the HTTP status code should be "200"
Expand Down
Loading