Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[full-ci][tests-only]Refactor share permission in coreApiSharePublicLinkShare #5494

Merged
merged 2 commits into from
Feb 14, 2023
Merged

[full-ci][tests-only]Refactor share permission in coreApiSharePublicLinkShare #5494

merged 2 commits into from
Feb 14, 2023

Conversation

amrita-shrestha
Copy link
Contributor

@amrita-shrestha amrita-shrestha commented Feb 1, 2023 •
edited
Loading

Description

As ownclouders decided #4052 (comment)

It was officially agreed that we do act differently than oc10. If the permissions requested by the client are not applicable we return an error (unlike oc10 which will downgrade permissions to 1)
Share permission behavior is different in oc10 and ocis.

This PR changes coreApiSharePublicLinkShare folder

  • refactor public link share permission related scenario
  • remove @skipOnOcis tagged scenario

FILES

  • accessToPublicLInkShare.feature (deleted because there is no tech preview feature in ocis verified by kulman)
  • changingPublicLinkShare.feature
  • createPublicLinkShare.feature
  • createPublicLInkShareToShares.feature (NOTHING TO DO)
  • deletePublicLinkShare.feature (NOTHING TO DO)

Related Issue

Motivation and Context

How Has This Been Tested?

  • locally

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@amrita-shrestha amrita-shrestha self-assigned this Feb 1, 2023
@amrita-shrestha amrita-shrestha force-pushed the refactor-share-permissiom-related-scenario branch from 9a98983 to 2a0b599 Compare February 1, 2023 11:20
@amrita-shrestha amrita-shrestha mentioned this pull request Feb 3, 2023
Closed
2 tasks
@amrita-shrestha amrita-shrestha force-pushed the refactor-share-permissiom-related-scenario branch from 2a0b599 to 4ca95a3 Compare February 13, 2023 15:24
@sonarcloud
Copy link

sonarcloud bot commented Feb 13, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

grgprarup
grgprarup approved these changes Feb 14, 2023
View reviewed changes
Copy link
Contributor

@grgprarup grgprarup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

SagarGi
SagarGi approved these changes Feb 14, 2023
View reviewed changes
Copy link
Member

@SagarGi SagarGi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@grgprarup grgprarup merged commit 2949b31 into stable-2.0 Feb 14, 2023
@delete-merged-branch delete-merged-branch bot deleted the refactor-share-permissiom-related-scenario branch February 14, 2023 04:19
ownclouders pushed a commit that referenced this pull request Feb 14, 2023
@amrita-shrestha
commit 2949b31
cef0bb1 
Author: Amrita <54478846+amrita-shrestha@users.noreply.github.com>
Date:   Tue Feb 14 10:04:08 2023 +0545

    [full-ci][tests-only]Refactor share permission in coreApiSharePublicLinkShare (#5494)

    * Refactor share permission related scenario
ownclouders pushed a commit that referenced this pull request Feb 15, 2023
@amrita-shrestha
commit 2949b31
e795de6 
Author: Amrita <54478846+amrita-shrestha@users.noreply.github.com>
Date:   Tue Feb 14 10:04:08 2023 +0545

    [full-ci][tests-only]Refactor share permission in coreApiSharePublicLinkShare (#5494)

    * Refactor share permission related scenario
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SagarGi SagarGi SagarGi approved these changes

@grgprarup grgprarup grgprarup approved these changes

@saw-jan saw-jan Awaiting requested review from saw-jan

@SwikritiT SwikritiT Awaiting requested review from SwikritiT

Assignees

@amrita-shrestha amrita-shrestha

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amrita-shrestha @grgprarup @SagarGi