Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[full-ci][tests-only]Forward-port refactor share permission in coreApiSharePublicLinkShare #5490

Merged
merged 2 commits into from
Feb 14, 2023
Merged

[full-ci][tests-only]Forward-port refactor share permission in coreApiSharePublicLinkShare #5490

merged 2 commits into from
Feb 14, 2023

Conversation

amrita-shrestha
Copy link
Contributor

@amrita-shrestha amrita-shrestha commented Feb 1, 2023 •
edited
Loading

Description

As ownclouders decided #4052 (comment)

It was officially agreed that we do act differently than oc10. If the permissions requested by the client are not applicable we return an error (unlike oc10 which will downgrade permissions to 1)
Share permission behavior is different in oc10 and ocis.

This PR changes coreApiSharePublicLinkShare folder

  • refactor public link share permission related scenario
  • remove @skipOnOcis tagged scenario

FILES

Related Issue

Motivation and Context

How Has This Been Tested?

  • locally

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@amrita-shrestha amrita-shrestha self-assigned this Feb 1, 2023
@amrita-shrestha amrita-shrestha force-pushed the refactor-share-permission-in-coreApiSharePublicLinkShare branch 2 times, most recently from 8f106e5 to b3be7c4 Compare February 1, 2023 09:49
@amrita-shrestha amrita-shrestha marked this pull request as ready for review February 1, 2023 09:49
@amrita-shrestha amrita-shrestha mentioned this pull request Feb 1, 2023
Merged
14 tasks
@amrita-shrestha amrita-shrestha force-pushed the refactor-share-permission-in-coreApiSharePublicLinkShare branch 2 times, most recently from 1f09670 to 38e8d08 Compare February 1, 2023 11:27
@amrita-shrestha amrita-shrestha mentioned this pull request Feb 2, 2023
Merged
14 tasks
@amrita-shrestha amrita-shrestha mentioned this pull request Feb 2, 2023
Merged
13 tasks
@amrita-shrestha amrita-shrestha force-pushed the refactor-share-permission-in-coreApiSharePublicLinkShare branch from 38e8d08 to 7b3cabe Compare February 3, 2023 04:01
@amrita-shrestha amrita-shrestha force-pushed the refactor-share-permission-in-coreApiSharePublicLinkShare branch from 7b3cabe to d64f49f Compare February 3, 2023 04:42
@amrita-shrestha amrita-shrestha mentioned this pull request Feb 3, 2023
Closed
2 tasks
@grgprarup grgprarup self-requested a review February 7, 2023 04:21
@grgprarup grgprarup self-requested a review February 7, 2023 04:22
@amrita-shrestha amrita-shrestha force-pushed the refactor-share-permission-in-coreApiSharePublicLinkShare branch from 682279c to 41d7a46 Compare February 7, 2023 04:31
saw-jan
saw-jan reviewed Feb 7, 2023
View reviewed changes
Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amrita-shrestha amrita-shrestha force-pushed the refactor-share-permission-in-coreApiSharePublicLinkShare branch 2 times, most recently from 140681c to a7d28a0 Compare February 7, 2023 17:05
@amrita-shrestha amrita-shrestha force-pushed the refactor-share-permission-in-coreApiSharePublicLinkShare branch 2 times, most recently from 9b2082c to 6a13b1e Compare February 9, 2023 03:22
@amrita-shrestha amrita-shrestha force-pushed the refactor-share-permission-in-coreApiSharePublicLinkShare branch 3 times, most recently from bd5ace0 to 482a9f9 Compare February 13, 2023 07:01
SagarGi
SagarGi reviewed Feb 14, 2023
View reviewed changes
Copy link
Member

@SagarGi SagarGi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍 if CI is happy

@amrita-shrestha amrita-shrestha changed the title [full-ci][tests-only]Refactor share permission in coreApiSharePublicLinkShare [full-ci][tests-only]Forward-port refactor share permission in coreApiSharePublicLinkShare Feb 14, 2023
@amrita-shrestha amrita-shrestha force-pushed the refactor-share-permission-in-coreApiSharePublicLinkShare branch from 482a9f9 to 3274361 Compare February 14, 2023 06:05
@sonarcloud
Copy link

sonarcloud bot commented Feb 14, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@phil-davis phil-davis merged commit 6a10559 into master Feb 14, 2023
@delete-merged-branch delete-merged-branch bot deleted the refactor-share-permission-in-coreApiSharePublicLinkShare branch February 14, 2023 08:37
ownclouders pushed a commit that referenced this pull request Feb 14, 2023
@phil-davis
commit 6a10559
ef7e383 
Merge: 2fec80f 3274361
Author: Phil Davis <phil@jankaritech.com>
Date:   Tue Feb 14 14:22:11 2023 +0545

    Merge pull request #5490 from owncloud/refactor-share-permission-in-coreApiSharePublicLinkShare

    [full-ci][tests-only]Forward-port refactor share permission in coreApiSharePublicLinkShare
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saw-jan saw-jan saw-jan left review comments

@SagarGi SagarGi SagarGi left review comments

@grgprarup grgprarup grgprarup approved these changes

@phil-davis phil-davis phil-davis approved these changes

@SwikritiT SwikritiT Awaiting requested review from SwikritiT

Assignees

@amrita-shrestha amrita-shrestha

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@amrita-shrestha @phil-davis @grgprarup @SwikritiT @SagarGi @saw-jan