Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only][full-ci]Refactor share permission related scenario in coreApiSharePublicLink3 #5502

Merged
merged 1 commit into from
Feb 13, 2023
Merged

[tests-only][full-ci]Refactor share permission related scenario in coreApiSharePublicLink3 #5502

merged 1 commit into from
Feb 13, 2023

Conversation

amrita-shrestha
Copy link
Contributor

@amrita-shrestha amrita-shrestha commented Feb 2, 2023 •
edited
Loading

Description

As ownclouders decided #4052 (comment)

It was officially agreed that we do act differently than oc10. If the permissions requested by the client are not applicable we return an error (unlike oc10 which will downgrade permissions to 1)
Share permission behavior is different in oc10 and ocis.

This PR changes coreApiSharePublicLinkShare folder

  • refactor public link share permission related scenario
  • remove @skipOnOcis tagged scenario

FILES

  • tests/acceptance/features/coreApiSharePublicLink3/allowGroupToCreatePublicLinks.feature (skipped) because we dont have the occ share related command Various sharing settings cannot be set #1328
  • tests/acceptance/features/coreApiSharePublicLink3/updatePublicLinkShare.feature
  • tests/acceptance/features/coreApiSharePublicLink3/uploadToPublicLinkShare.feature
  • tests/acceptance/features/coreApiSharePublicLink3/uploadToPublicLinkShare.feature

Related Issue

Motivation and Context

How Has This Been Tested?

  • locally

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@amrita-shrestha amrita-shrestha self-assigned this Feb 2, 2023
@amrita-shrestha amrita-shrestha force-pushed the refactor-share-permission-coreApiSharePublicLink3 branch from b68865a to d0117c3 Compare February 3, 2023 04:18
@amrita-shrestha amrita-shrestha mentioned this pull request Feb 3, 2023
Closed
2 tasks
@amrita-shrestha amrita-shrestha force-pushed the refactor-share-permission-coreApiSharePublicLink3 branch 3 times, most recently from 1908e4b to f665a5c Compare February 7, 2023 16:57
@amrita-shrestha amrita-shrestha marked this pull request as ready for review February 8, 2023 03:52
SagarGi
SagarGi reviewed Feb 9, 2023
View reviewed changes
Copy link
Member

@SagarGi SagarGi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

other than above comment LGTM 👍

@amrita-shrestha amrita-shrestha force-pushed the refactor-share-permission-coreApiSharePublicLink3 branch 3 times, most recently from a82ccea to 8132c39 Compare February 13, 2023 04:30
@amrita-shrestha amrita-shrestha force-pushed the refactor-share-permission-coreApiSharePublicLink3 branch from 8132c39 to b06983f Compare February 13, 2023 06:10
@sonarcloud
Copy link

sonarcloud bot commented Feb 13, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

grgprarup
grgprarup approved these changes Feb 13, 2023
View reviewed changes
Copy link
Contributor

@grgprarup grgprarup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amrita-shrestha amrita-shrestha merged commit c80dbea into stable-2.0 Feb 13, 2023
@delete-merged-branch delete-merged-branch bot deleted the refactor-share-permission-coreApiSharePublicLink3 branch February 13, 2023 09:59
ownclouders pushed a commit that referenced this pull request Feb 13, 2023
@amrita-shrestha
commit c80dbea
b97e224 
Merge: b68914b b06983f
Author: Amrita <54478846+amrita-shrestha@users.noreply.github.com>
Date:   Mon Feb 13 15:44:23 2023 +0545

    Merge pull request #5502 from owncloud/refactor-share-permission-coreApiSharePublicLink3

    [tests-only][full-ci]Refactor share permission related scenario in coreApiSharePublicLink3
@amrita-shrestha amrita-shrestha mentioned this pull request Feb 13, 2023
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grgprarup grgprarup grgprarup approved these changes

@SagarGi SagarGi SagarGi approved these changes

@SwikritiT SwikritiT Awaiting requested review from SwikritiT

@phil-davis phil-davis Awaiting requested review from phil-davis

@saw-jan saw-jan Awaiting requested review from saw-jan

Assignees

@amrita-shrestha amrita-shrestha

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@amrita-shrestha @grgprarup @SagarGi @saw-jan