Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only][full-ci]Refactor share permission related scenario in coreApiSharePublicLink2 #5501

Conversation

amrita-shrestha
Copy link
Contributor

Description

As ownclouders decided #4052 (comment)

It was officially agreed that we do act differently than oc10. If the permissions requested by the client are not applicable we return an error (unlike oc10 which will downgrade permissions to 1)
Share permission behavior is different in oc10 and ocis.

This PR changes coreApiSharePublicLinkShare folder

  • refactor public link share permission related scenario
  • remove @skipOnOcis tagged scenario

FILES

  • copyFromPublicLink.feature (NOTHING TO DO)
  • multilinkSharing.feature (removed skiponoc10 tag)
  • reShareAsPublicLinkToSharesNewDav.feature
  • reShareAsPublicLinkToRoot.feature (deleted)
  • reShareAsPublicLinkToSharesOldDav.feature (deleted)

Related Issue

Motivation and Context

How Has This Been Tested?

  • locally

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@update-docs
Copy link

update-docs bot commented Feb 2, 2023

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@amrita-shrestha amrita-shrestha changed the title Refactor share permission related scenario [tests-only][full-ci]Refactor share permission related scenario in coreApiSharePublicLink2 Feb 2, 2023
@amrita-shrestha amrita-shrestha force-pushed the refactor-share-permission-coreApiSharePublicLink2 branch from e4d312c to 388ec1f Compare February 2, 2023 06:00
@sonarcloud
Copy link

sonarcloud bot commented Feb 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@amrita-shrestha amrita-shrestha marked this pull request as ready for review February 2, 2023 07:09
Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amrita-shrestha amrita-shrestha merged commit d3a1c36 into stable-2.0 Feb 2, 2023
@delete-merged-branch delete-merged-branch bot deleted the refactor-share-permission-coreApiSharePublicLink2 branch February 2, 2023 09:20
ownclouders pushed a commit that referenced this pull request Feb 2, 2023
Merge: 9983aa7 388ec1f
Author: Amrita <54478846+amrita-shrestha@users.noreply.github.com>
Date:   Thu Feb 2 15:05:17 2023 +0545

    Merge pull request #5501 from owncloud/refactor-share-permission-coreApiSharePublicLink2

    [tests-only][full-ci]Refactor share permission related scenario in coreApiSharePublicLink2
ownclouders pushed a commit that referenced this pull request Feb 3, 2023
Merge: 9983aa7 388ec1f
Author: Amrita <54478846+amrita-shrestha@users.noreply.github.com>
Date:   Thu Feb 2 15:05:17 2023 +0545

    Merge pull request #5501 from owncloud/refactor-share-permission-coreApiSharePublicLink2

    [tests-only][full-ci]Refactor share permission related scenario in coreApiSharePublicLink2
ownclouders pushed a commit that referenced this pull request Feb 3, 2023
Merge: 9983aa7 388ec1f
Author: Amrita <54478846+amrita-shrestha@users.noreply.github.com>
Date:   Thu Feb 2 15:05:17 2023 +0545

    Merge pull request #5501 from owncloud/refactor-share-permission-coreApiSharePublicLink2

    [tests-only][full-ci]Refactor share permission related scenario in coreApiSharePublicLink2
ownclouders pushed a commit that referenced this pull request Feb 4, 2023
Merge: 9983aa7 388ec1f
Author: Amrita <54478846+amrita-shrestha@users.noreply.github.com>
Date:   Thu Feb 2 15:05:17 2023 +0545

    Merge pull request #5501 from owncloud/refactor-share-permission-coreApiSharePublicLink2

    [tests-only][full-ci]Refactor share permission related scenario in coreApiSharePublicLink2
ownclouders pushed a commit that referenced this pull request Feb 5, 2023
Merge: 9983aa7 388ec1f
Author: Amrita <54478846+amrita-shrestha@users.noreply.github.com>
Date:   Thu Feb 2 15:05:17 2023 +0545

    Merge pull request #5501 from owncloud/refactor-share-permission-coreApiSharePublicLink2

    [tests-only][full-ci]Refactor share permission related scenario in coreApiSharePublicLink2
ownclouders pushed a commit that referenced this pull request Feb 6, 2023
Merge: 9983aa7 388ec1f
Author: Amrita <54478846+amrita-shrestha@users.noreply.github.com>
Date:   Thu Feb 2 15:05:17 2023 +0545

    Merge pull request #5501 from owncloud/refactor-share-permission-coreApiSharePublicLink2

    [tests-only][full-ci]Refactor share permission related scenario in coreApiSharePublicLink2
ownclouders pushed a commit that referenced this pull request Feb 6, 2023
Merge: 9983aa7 388ec1f
Author: Amrita <54478846+amrita-shrestha@users.noreply.github.com>
Date:   Thu Feb 2 15:05:17 2023 +0545

    Merge pull request #5501 from owncloud/refactor-share-permission-coreApiSharePublicLink2

    [tests-only][full-ci]Refactor share permission related scenario in coreApiSharePublicLink2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants