listing drives sould use the user filter #6103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
butonic
force-pushed
the
drive-should-send-userfilter
branch
from
519d7ec
to
558df1b
Compare
|
💥 Acceptance test localApiTests-apiGraph-ocis failed. Further test are cancelled... |
|
@aduffeck duh we are not invalidating the filemetadata cache when deleting a space ... needs a reva fix |
butonic
force-pushed
the
drive-should-send-userfilter
branch
from
558df1b
to
b997ce6
Compare
butonic
changed the title
butonic
commented
Apr 25, 2023
| @@ -469,7 +479,7 @@ var _ = Describe("Graph", func() { | |||
| r := httptest.NewRequest(http.MethodPost, "/graph/v1.0/drives", bytes.NewBuffer(jsonBody)).WithContext(ctx) | |||
| rr := httptest.NewRecorder() | |||
| svc.CreateDrive(rr, r) | |||
| Expect(rr.Code).To(Equal(http.StatusUnauthorized)) | |||
| Expect(rr.Code).To(Equal(http.StatusForbidden)) | |||
butonic
force-pushed
the
drive-should-send-userfilter
branch
from
fd672dd
to
7d5aa70
Compare
aduffeck
force-pushed
the
drive-should-send-userfilter
branch
2 times, most recently
from
547f22b
to
422f671
Compare
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
butonic
force-pushed
the
drive-should-send-userfilter
branch
from
422f671
to
245d9dd
Compare
|
needs cs3org/reva#3826 |
aduffeck
force-pushed
the
drive-should-send-userfilter
branch
2 times, most recently
from
7a75fdd
to
b074537
Compare
aduffeck
force-pushed
the
drive-should-send-userfilter
branch
from
b074537
to
8cc57ba
Compare
|
Kudos, SonarCloud Quality Gate passed! |
ownclouders
pushed a commit
that referenced
this pull request
Apr 28, 2023
* listing drives shsould use the user filter Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de> * fix status code Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de> * check correct error Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de> * Adapt expected failures * Bump reva --------- Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de> Co-authored-by: André Duffeck <andre.duffeck@firondu.de>
86 tasks
2 tasks
fschade
pushed a commit
that referenced
this pull request
Jul 10, 2023
* listing drives shsould use the user filter Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de> * fix status code Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de> * check correct error Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de> * Adapt expected failures * Bump reva --------- Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de> Co-authored-by: André Duffeck <andre.duffeck@firondu.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when a user lists all spaces he has access to (unrestricted==false) we should send a user filter, so decomposedfs has a chance to use an index instead of iterating over ALL spaces.
part of todays tracing session, the reva part is in cs3org/reva#3809
blocked by cs3org/reva#3826blocked by cs3org/reva#3827