Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ocis 5455 language setting #7720

Merged
merged 16 commits into from
Nov 15, 2023

Conversation

dragonchaser
Copy link
Member

@dragonchaser dragonchaser commented Nov 13, 2023

Enhancement: Add preferred language to user settings

We have added the preferred language to the libre-graph api & added endpoints for that to ocis.

refs #5455
refs owncloud/libre-graph-api#130

@owncloud owncloud deleted a comment from update-docs bot Nov 13, 2023
@kobergj
Copy link
Collaborator

kobergj commented Nov 13, 2023

Please rebase to master as there were changes to settings service that might impact this PR

services/graph/pkg/service/v0/users.go Outdated Show resolved Hide resolved
@dragonchaser dragonchaser force-pushed the ocis-5455-language-setting branch 4 times, most recently from 03eeb54 to f58c435 Compare November 14, 2023 15:29
@dragonchaser dragonchaser marked this pull request as ready for review November 14, 2023 15:32
@AlexAndBear AlexAndBear self-requested a review November 14, 2023 16:03
Copy link
Contributor

@fschade fschade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just minor nitpicks... up to you

services/graph/pkg/service/v0/service.go Show resolved Hide resolved
services/graph/pkg/service/v0/users.go Show resolved Hide resolved
@dragonchaser dragonchaser marked this pull request as draft November 14, 2023 17:17
@dragonchaser
Copy link
Member Author

We have found a massive bug, the language is not correctly stored and retrieved, working on it

@ScharfViktor
Copy link
Contributor

e2e test error. whether your changes could have affected the GET user https://ocis-server:9200/graph/v1.0/users/793967d8-ed19-4c77-95fa-f335189f1fd4?%24select=&%24expand=drive%2CmemberOf%2CappRoleAssignments in any way?

https://drone.owncloud.com/owncloud/ocis/28760/40/12
trace: npx playwright show-trace https://cache.owncloud.com/public/owncloud/ocis/28760/tracing/user-should-be-able-to-read-and-dismiss-notifications-alice-2023-11-15-07-37-20.zip

Screenshot 2023-11-15 at 09 19 12

dragonchaser and others added 12 commits November 15, 2023 11:23
Signed-off-by: Christian Richter <crichter@owncloud.com>
Signed-off-by: Christian Richter <crichter@owncloud.com>
Signed-off-by: Christian Richter <crichter@owncloud.com>
Signed-off-by: Christian Richter <crichter@owncloud.com>
Co-authored-by: Julian Koberg <jkoberg@owncloud.com>
Co-authored-by: Michael Barz <mbarz@owncloud.com>
Signed-off-by: Christian Richter <crichter@owncloud.com>
Signed-off-by: Christian Richter <crichter@owncloud.com>
Signed-off-by: Christian Richter <crichter@owncloud.com>
Signed-off-by: Christian Richter <crichter@owncloud.com>
… language

Co-authored-by: Florian Schade <fschade@owncloud.com>
Signed-of-by: Christian Richter <crichter@owncloud.com>
Signed-off-by: Christian Richter <crichter@owncloud.com>
Signed-off-by: Christian Richter <crichter@owncloud.com>
Signed-off-by: Christian Richter <crichter@owncloud.com>
dragonchaser and others added 2 commits November 15, 2023 11:23
Signed-off-by: Christian Richter <crichter@owncloud.com>
Co-authored-by: Julian Koberg <jkoberg@owncloud.com>
Co-authored-by: Ralf Haferkamp <rhaferkamp@owncloud.com>
Signed-off-by: Christian Richter <crichter@owncloud.com>
@dragonchaser dragonchaser force-pushed the ocis-5455-language-setting branch 2 times, most recently from d3d4ba2 to 6ec9891 Compare November 15, 2023 12:06
Co-authored-by: Julian Koberg <jkoberg@owncloud.com>
Co-authored-by: Ralf Haferkamp <rhaferkamp@owncloud.com>
Co-authored-by: Michael Barz <mbarz@owncloud.com>
Signed-off-by: Christian Richter <crichter@owncloud.com>
Co-authored-by: Florian Schade <fschade@owncloud.com>

Signed-off-by: Christian Richter <crichter@owncloud.com>
Copy link

sonarcloud bot commented Nov 15, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

32.3% 32.3% Coverage
0.0% 0.0% Duplication

@dragonchaser dragonchaser marked this pull request as ready for review November 15, 2023 12:58
return "", "", err
}

langVal := gvr.GetValue().GetValue().GetListValue().GetValues()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fishy.... but seems to be ok

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Results from generated Code 🤷

@dragonchaser dragonchaser merged commit 50eff6d into owncloud:master Nov 15, 2023
2 checks passed
@dragonchaser dragonchaser deleted the ocis-5455-language-setting branch November 15, 2023 13:11
ownclouders pushed a commit that referenced this pull request Nov 15, 2023
ownclouders pushed a commit that referenced this pull request Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants