Language settings via graph #9924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
AlexAndBear
commented
Nov 9, 2023
AlexAndBear
commented
Nov 9, 2023
Comment on lines
-28
to
-34
| he: 'עִבְרִית', | ||
| it: 'Italiano', | ||
| pl: 'Polski', | ||
| ru: 'русский язык', | ||
| sk: 'Slovenčina', | ||
| sq: 'Shqipja', | ||
| tr: 'Türkçe' |
There was a problem hiding this comment.
Removed languages that are not exposed via settings service, for now
AlexAndBear
commented
Nov 9, 2023
| if (currentLanguage.indexOf('_')) { | ||
| currentLanguage = currentLanguage.split('_')[0] | ||
| if (currentLanguage.indexOf('-')) { | ||
| currentLanguage = currentLanguage.split('-')[0] |
There was a problem hiding this comment.
switch to ISO Language code
AlexAndBear
commented
Nov 9, 2023
| value: unref(spacesEnabled) ? $gettext('Personal') : $gettext('All files') | ||
| }) | ||
| } | ||
| store.commit('SET_LANGUAGE', language.current) |
There was a problem hiding this comment.
we didn't do that before, but I think we should
AlexAndBear
commented
Nov 10, 2023
lookacat
approved these changes
Nov 10, 2023
AlexAndBear
force-pushed
the
language-settings-graph
branch
from
426063a
to
bfa0f3f
Compare
JammingBen
reviewed
Nov 10, 2023
AlexAndBear
force-pushed
the
language-settings-graph
branch
from
b19c5ad
to
9ad0f52
Compare
AlexAndBear
commented
Nov 14, 2023
AlexAndBear
commented
Nov 15, 2023
AlexAndBear
force-pushed
the
language-settings-graph
branch
2 times, most recently
from
91f9614
to
3454d03
Compare
JammingBen
approved these changes
Nov 15, 2023
JammingBen
force-pushed
the
language-settings-graph
branch
from
05987a7
to
bbf8cea
Compare
|
SonarCloud Quality Gate failed.
|
ownclouders
pushed a commit
that referenced
this pull request
Nov 16, 2023
AlexAndBear
added a commit
that referenced
this pull request
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist:
Open tasks: