Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add a config for default link permissions #7783

Merged
merged 2 commits into from
Nov 23, 2023

Conversation

JammingBen
Copy link
Contributor

Description

Adds a new config for default link permissions that is being announced via capabilities. It defaults to 1 (= public link with viewer permissions).

Needs a part in reva: cs3org/reva#4358.

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

@JammingBen JammingBen self-assigned this Nov 22, 2023
Co-authored-by: Martin <github@diemattels.at>
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@JammingBen JammingBen marked this pull request as ready for review November 22, 2023 13:24
Copy link
Contributor

@mmattel mmattel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from a docs pov 👍

Copy link
Contributor

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@JammingBen JammingBen merged commit 8ee0310 into master Nov 23, 2023
1 check passed
@delete-merged-branch delete-merged-branch bot deleted the link-default-permissions-capability branch November 23, 2023 06:59
ownclouders pushed a commit that referenced this pull request Nov 23, 2023
* feat: add a config for default link permissions

* Update services/frontend/pkg/config/config.go

---------

Co-authored-by: Martin <github@diemattels.at>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants