Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only][full-ci] added test coverage for sharing file between spaces via secure view role #9445

Merged
merged 1 commit into from
Aug 6, 2024
Merged

[tests-only][full-ci] added test coverage for sharing file between spaces via secure view role #9445

merged 1 commit into from
Aug 6, 2024

Conversation

S-Panta
Copy link
Contributor

@S-Panta S-Panta commented Jun 24, 2024 •
edited
Loading

Description

Adding test scenario for sharing file via secure roles among the spaces

Scenario: user copies a file from share space with secure viewer role to personal space
Scenario Outline: user copies a file from share space with secure viewer role to project space with different role
Scenario Outline: user copies a file from share space with different role to share space with role viewer or space viewer

Related Issue

How Has This Been Tested?

  • test environment:
  • locally and CI
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@S-Panta S-Panta self-assigned this Jun 24, 2024
@S-Panta S-Panta mentioned this pull request Jun 24, 2024
Closed
11 tasks
@S-Panta S-Panta marked this pull request as ready for review June 24, 2024 09:09
@S-Panta S-Panta force-pushed the copy-file-secure-view-share-in-project-space branch 3 times, most recently from 0722a02 to 2c8c011 Compare June 25, 2024 12:31
@S-Panta
Copy link
Contributor Author

S-Panta commented Jun 27, 2024 •
edited
Loading

Copying file from Secure view share to personal space returns 500 status code.
Related issue for that: #9482
Therefore the PR is moved to blocked
Fixed by #9677 . If this dev PR get merged, current test PR will pass

@S-Panta S-Panta force-pushed the copy-file-secure-view-share-in-project-space branch 2 times, most recently from c185bec to 9e5889d Compare July 24, 2024 06:42
@S-Panta S-Panta mentioned this pull request Jul 24, 2024
Merged
9 tasks
@S-Panta S-Panta force-pushed the copy-file-secure-view-share-in-project-space branch from 9e5889d to 03fa700 Compare July 25, 2024 12:17
@S-Panta S-Panta requested a review from saw-jan July 26, 2024 04:00
@S-Panta S-Panta force-pushed the copy-file-secure-view-share-in-project-space branch 2 times, most recently from b811c60 to eeb8acc Compare July 26, 2024 06:36
@S-Panta S-Panta force-pushed the copy-file-secure-view-share-in-project-space branch from eeb8acc to c950e78 Compare July 26, 2024 07:57
@prashant-gurung899 prashant-gurung899 force-pushed the copy-file-secure-view-share-in-project-space branch from c950e78 to ef251ef Compare August 5, 2024 10:49
@S-Panta @prashant-gurung899
added test coverage for sharing file between spaces via secure view role
b1e55a2 
updated expected failures file

addhressing reviews
@prashant-gurung899 prashant-gurung899 force-pushed the copy-file-secure-view-share-in-project-space branch from ef251ef to b1e55a2 Compare August 5, 2024 11:30
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Aug 5, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@saw-jan saw-jan requested a review from ishabaral August 6, 2024 06:18
saw-jan
saw-jan approved these changes Aug 6, 2024
View reviewed changes
Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@saw-jan saw-jan merged commit 840eb73 into master Aug 6, 2024
4 checks passed
@saw-jan saw-jan deleted the copy-file-secure-view-share-in-project-space branch August 6, 2024 09:17
ownclouders pushed a commit that referenced this pull request Aug 6, 2024
@saw-jan
Merge pull request #9445 from owncloud/copy-file-secure-view-share-in…
fbe8f41 
…-project-space

[tests-only][full-ci] added test coverage for sharing file between spaces via secure view role
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saw-jan saw-jan saw-jan approved these changes

@phil-davis phil-davis phil-davis approved these changes

@grgprarup grgprarup Awaiting requested review from grgprarup

@SagarGi SagarGi Awaiting requested review from SagarGi

@nirajacharya2 nirajacharya2 Awaiting requested review from nirajacharya2

@amrita-shrestha amrita-shrestha Awaiting requested review from amrita-shrestha

@anon-pradip anon-pradip Awaiting requested review from anon-pradip

@ishabaral ishabaral Awaiting requested review from ishabaral

Assignees

@prashant-gurung899 prashant-gurung899

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@S-Panta @phil-davis @SagarGi @saw-jan @prashant-gurung899