Skip to content
This repository has been archived by the owner on Jan 3, 2024. It is now read-only.

Only allow hover in OcTable when enabled #1978

Merged
merged 1 commit into from
Feb 24, 2022

Conversation

pascalwengerter
Copy link
Contributor

Seems to have gone unnoticed in #1958, but suddenly we had a hover on the OcTable footer. This kinda reverts the changes to only allow hover on none-footer-cells and when hovering is enabled for the component via its props

@sonarcloud
Copy link

sonarcloud bot commented Feb 24, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@lookacat lookacat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good finding!

Copy link
Contributor

@lookacat lookacat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good finding!

Copy link
Contributor

@lookacat lookacat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good finding!

@pascalwengerter pascalwengerter merged commit 6776884 into master Feb 24, 2022
@delete-merged-branch delete-merged-branch bot deleted the no-octable-footer-hover branch February 24, 2022 19:07
@pascalwengerter pascalwengerter mentioned this pull request Feb 24, 2022
24 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants