Skip to content
This repository has been archived by the owner on Jan 3, 2024. It is now read-only.

Redesign FilesTable #1958

Merged
merged 8 commits into from
Feb 21, 2022
Merged

Redesign FilesTable #1958

merged 8 commits into from
Feb 21, 2022

Conversation

lookacat
Copy link
Contributor

@lookacat lookacat commented Feb 14, 2022

Description

See owncloud/web#6207

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation added/updated

@update-docs
Copy link

update-docs bot commented Feb 14, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@lookacat lookacat changed the title redesign files table Redesign FilesTable Feb 17, 2022
@lookacat lookacat marked this pull request as ready for review February 17, 2022 16:16
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found some small things.
Regarding the new color variable I'm a bit confused now. I thought that the background-secondary was supposed to be another surface color variable with the color value that was previously given to the highlight color. And that you wanted to come up with a completely new color for the already existing background-highlight color. 🤔 could you resolve my confusion?

src/components/organisms/OcResource/OcResource.vue Outdated Show resolved Hide resolved
src/components/atoms/OcCheckbox/OcCheckbox.vue Outdated Show resolved Hide resolved
changelog/unreleased/enhancement-redesign-filestable Outdated Show resolved Hide resolved
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Still not happy with the usage/changes regarding color variables (see detailed comment)
  • Sorting icons in table header are only visible on hover in dark mode. In light mode not even on hover. In both modes not permanently for the currently sorted column.

But:

  • OcCheckbox looks really good again 🥳

src/components/atoms/OcCheckbox/OcCheckbox.vue Outdated Show resolved Hide resolved
src/tokens/ods/color.yaml Outdated Show resolved Hide resolved
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍 Discussed in a call that you'll add the background-hover color token for highlighting in the files table, that's also good to get in.

@sonarcloud
Copy link

sonarcloud bot commented Feb 21, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants