This repository has been archived by the owner on Jan 3, 2024. It is now read-only.
Fix resource icons/thumbnails only visible for clickable resources #2007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
10 tasks
dschmidt
force-pushed
the
resource_show_placeholders
branch
from
02475a2
to
fdd86b5
Compare
... and fix icons/thumbnails not being shown if the resource is not clickable.
dschmidt
force-pushed
the
resource_show_placeholders
branch
from
fdd86b5
to
b87ac0f
Compare
|
Kudos, SonarCloud Quality Gate passed! |
lookacat
approved these changes
Mar 7, 2022
|
@pascalwengerter I've fulfilled your request, can you un-request changes, so I can merge? :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While working on owncloud/web#6534 I was wondering why disabling thumbnails also (seemingly) disabled placeholder icons.
It turns out they are disabled for non-clickable resources, which hardly makes any sense to me.
This behavior was introduced (hopefully) by mistake in #1958 (or more specifically 2b314c9)
No tests added as the code is already tested as part of
OcResource.Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: