Skip to content
This repository has been archived by the owner on Jan 3, 2024. It is now read-only.

Ad OcResource parentfolder name prop #2029

Merged
merged 2 commits into from
Mar 21, 2022

Conversation

pascalwengerter
Copy link
Contributor

Makes default parent folder name configurable for web to differentiate between "All files" (former fallback, needed for OC10) and "Personal/{spaceName}" in oCIS

@pascalwengerter pascalwengerter force-pushed the enhancement-ocresource-parentfolder-prop branch from 2dd74eb to 9efa1cb Compare March 18, 2022 10:27
@kulmann
Copy link
Member

kulmann commented Mar 18, 2022

Makes default parent folder name configurable for web to differentiate between "All files" (former fallback, needed for OC10) and "Personal/{spaceName}" in oCIS

... also for a space root :-)

@kulmann kulmann mentioned this pull request Mar 18, 2022
25 tasks
src/components/organisms/OcResource/OcResource.spec.js Outdated Show resolved Hide resolved
stubs,
})

expect(wrapper).toMatchSnapshot()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Snapshot test is not necessary here. Can check the parent folder name text directly (compare with the default that was given in propsData)

src/components/organisms/OcResource/OcResource.spec.js Outdated Show resolved Hide resolved
src/components/organisms/OcResource/OcResource.vue Outdated Show resolved Hide resolved
@pascalwengerter pascalwengerter force-pushed the enhancement-ocresource-parentfolder-prop branch from 9efa1cb to 71bbc13 Compare March 21, 2022 15:31
@pascalwengerter pascalwengerter force-pushed the enhancement-ocresource-parentfolder-prop branch from 71bbc13 to d987d05 Compare March 21, 2022 15:34
@sonarcloud
Copy link

sonarcloud bot commented Mar 21, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@pascalwengerter pascalwengerter changed the title Enhancement ocresource parentfolder prop Ad OcResource parentfolder name prop Mar 21, 2022
@kulmann kulmann merged commit 4b16915 into master Mar 21, 2022
@delete-merged-branch delete-merged-branch bot deleted the enhancement-ocresource-parentfolder-prop branch March 21, 2022 15:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants