This repository has been archived by the owner on Jan 3, 2024. It is now read-only.
Ad OcResource parentfolder name prop #2029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pascalwengerter
force-pushed
the
enhancement-ocresource-parentfolder-prop
branch
from
2dd74eb
to
9efa1cb
Compare
... also for a space root :-) |
kulmann
suggested changes
Mar 21, 2022
| stubs, | ||
| }) | ||
|
|
||
| expect(wrapper).toMatchSnapshot() |
There was a problem hiding this comment.
Snapshot test is not necessary here. Can check the parent folder name text directly (compare with the default that was given in propsData)
pascalwengerter
force-pushed
the
enhancement-ocresource-parentfolder-prop
branch
from
9efa1cb
to
71bbc13
Compare
pascalwengerter
force-pushed
the
enhancement-ocresource-parentfolder-prop
branch
from
71bbc13
to
d987d05
Compare
|
Kudos, SonarCloud Quality Gate passed! |
pascalwengerter
changed the title
kulmann
approved these changes
Mar 21, 2022
delete-merged-branch
bot
deleted the
enhancement-ocresource-parentfolder-prop
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes default parent folder name configurable for
webto differentiate between "All files" (former fallback, needed for OC10) and "Personal/{spaceName}" in oCIS