Release 5.3.0

[fschade]

Waiting for

• [full-ci] Use resharing capability instead of hardcoding isOcis #6619
• Show space members in the share panel for regular files inside a space #6554
• Implement people sharing for resources within a space #6577
• Add the 'space_ref' param to the share management owncloud-sdk#1025
• Ad OcResource parentfolder name prop owncloud-design-system#2029

Release checklist

• pin release issue @fschade
• prepare release rc
  • create a branch release-5.3.0 @fschade
  • update the version in packages/web-integration-oc10/appinfo/info.xml @fschade
  • update the version in package.json @fschade
  • update the version in sonar-project.properties @fschade
  • move changelog/unreleased/* to changelog/VERSION_YYYY-MM-DD @fschade
  • update the ocis commit id in .drone.env to the most recent one from ocis master (let's see how it goes) @fschade
  • commit, push and create draft PR for this branch @fschade
• create pre release tag v5.3.0-rc.1 from the release branch @pascalwengerter
• create pre release tag v5.3.0-rc.2 from the release branch @fschade
• create pre release tag v5.3.0-rc.3 from the release branch
• smoke test
  • against oCIS @ScharfViktor
  • against oc10 as sidecar deployment @fschade
  • against oc10 as app installation @pascalwengerter
  • against oCIS wopi example / app provider @pascalwengerter
  • against oc10 with OnlyOffice app installed
• if needed, fix issues or write down known issues
• update YYYY-MM-DD to current date in changelog/VERSION_YYYY-MM-DD @pascalwengerter
• Make sure translations are up to date by updating them in Transifex and restarting translation sync job https://drone.owncloud.com/owncloud/translation-sync/ @pascalwengerter
• repeat above steps if a new rc is needed
• Run translations sync job once again @pascalwengerter
• go to the releases section and click Draft a new Release. Use v5.3.0 as a tag (the v prefix is important) and 5.3.0 as name and publish it @pascalwengerter
• ping in internal #btr channel to create a signed release and ask them to upload it to a) the github release page, b) marketplace.owncloud.com, c) portal.owncloud.com, d) customer.owncloud.com
• merge release branch back to master (CI must be green)

[ScharfViktor]

SmokeTest against ocis

branch: v5.3.0-rc.3

Case 1: admin share folder(with file) to marie:

Admin:

• upload big file 10gb - slow and uploads partly because of page refreshing
• upload folder with 803 small images.
• Check pagination, count items per page
• upload folder(drag folder) "folder_to_share" with file.pdf
• share folder "folder_to_share" to marie with edit right

Marie:

• accept "folder_to_share"
• rename "folder_to_share"
• upload new file "file.txt" to "folder_to_share" (admin see new file)
• open pdf file
• rename file.pdf (use rigth click) (admin see that file changed name)

Admin:

• add new file.jpeg to "folder_to_share"
• add file format drawio (marie can open in Draw.io and can edit)
• move file.pdf to root "personal" (marie can not see file.pdf)
• add new "file.txt" create new version. (use drag and drop)
• open txt file in markdown-editor. Change and save.

Marie:

• 🚫 can download both versions (!error 501)
• restore old version

Admin:

• change share "folder_to_share" from "edit" to "viewer" (marie cannot rename/move/delete/download file in folder and cannot create new document in the folder)

Marie:

• decline folder (removed from shares folder)
• accept again

Admin:

• delete folder "folder_to_share" (removed from shared with me, removed from Marie)

Case 2: admin share file to marie:

Admin:

• upload file.jpeg
• share file.jpeg to marie with rigth viewer (use main menu. find marie by email marie@example.org)

Marie:

• accept file (marie can open/download/copy file but cannot delete/move/rename)
• copy file to "/"
• open file in Mediaviewer
• download file

Admin:

• change share "file.jpeg" from "viewer" to "edit"(marie can open/download/copy/rename file)

Marie:

• rename file (🚫admin don't see)

Admin:

• unshare "file.jpeg" (marie cannot see "file.jpeg" in Shares/Shared for me but see the copied file)

Case 3: admin create public links to folder

Admin:

• create folder "for upload"
• add link with name "to_upload" with role "Uploader" with pass and expiration date
• open link (can only upload)
• upload file (admin can see new file)
• refresh page(page is empty)
• 🚫 change share "for upload" from "Uploader" to "edit" Bug: Public link. Change role doesn't work #6429
• 🚫 open old link (it work as upload)
• 🚫 open new link (can open/download/copy/rename/move files) - works as upload
• create new link with role editor
• admin add new file to "for upload"
• refresh link (file exist)
• admin change pass (refresh link has to type new pass)

Case 4: admin create link to file

Admin:

• create file png
• add link with main menu
• open link(can open, download, see) in the incognito tab
• change link, add pass
• refresh page (input pass)
• delete link
• refresh page (resource not found)
• delete file
• restore
• delete
• Empty trash

Case 5: create new user:

Admin:

• create new account "tom" / How can I change my user name or password?
• log in as tom
• 🚫 user with user rights has an accounts tab. Is this correct? But it cannot see users and create new users - this is good
• change language
• admin blocks and deletes user "tom"

Findings:

there is nothing blocking release

[fschade]

@ScharfViktor please wait a few moments more, we still have to add at least 1 pr before testing can start.
Thanks for you really fast support ❤️

[ScharfViktor]

Oops, that was a rush. Please ping me when it will be ready for smoke test.

[pascalwengerter]

Tested the release candidate in combination with a patched app-provider (owncloud/ocis#3333), it works better than the completely broken state before somehow but I don't think there's a lot on the web side of things that can be done here

[fschade]

@ScharfViktor thanks for the testing, the accounts button link in settings is not an release blocker.

[fschade]

sideCar mode tested and works, i didn't go into detail here because the oc10 app cover all other topics.

[pascalwengerter]

Smoke test v5.3.0-rc.3 against oc10 app

• ✔️ as admin - upload personal university archive (~3.000 files)
  - via drag and drop folder upload works
  - via folder upload button works

  • progress bar is not sticky
  • expanding the upload progress section slows down browser & upload time significantly

• ✔️ as admin - share the folder to alice as viewer
  - sharing is not possible before the upload finished (user invite field doesn't stay focussed)

• ✔️ as alice - share is already accepted. declining and accepting again works as expected (buttons in shared with me table, batch action, right sidebar)

• ✔️ as alice - try do delete file from shared folder
  - individual delete action not visible, good
  - batch delete action not visible, good
  - context menu action not visible, goods

• ✔️ as alice - try to add file
  - not possible (which is expected) but drag & drop upload didn't handle it. opened file in new tab instead.

• ❌ as alice - copy 16 folders from share to home

  • no visible feedback that it's in progress
  • UI still weirdly usable, ended up in an active upload drop zone. Needed a page reload to be usable again.

• ✔️ as admin - add new file to share

• ✔️ as alice - receive new file in existing share

• ✔️ as admin - unshare folder from shared with others

• ✔️ as alice - try to revisit old share

  • shows resource not found upon page reload, good
  • going back to All files or Shared with me doesn't list the share anymore, good

• ✔️ as admin - share folder with alice again, but as editor
  - setting and removing an expiration date work as expected, good

• ✔️ as alice - rename a file

  • via right sidebar, works, good
  • via context menu, works, good

• ✔️ as admin - add file

• ✔️ as alice - delete file

  • via right sidebar, works, good
  • via context menu, works, good
  • via batch action, works, good

• ✔️ as alice - create public link on any folder

• ✔️ as alice delete file and recover it

• ✔️ as alice create version of textfile

• ✔️ as alice view version history of text file

• ✔️ as alice download newest version of text file

• ✔️ download older version of text file

• ✔️ restore older version of text file

  • no visible feedback about the success
  • preview is not updated

• ✔️ as alice - upload avatar in classic UI

  • see own avatar in top bar (far right)
  • login as admin, having a share with alice
    • ❌ shared with others page loads and shows avatars
    • ✔️ see alice's avatar in people share sidebar

• ✔️ as alice, move a file into subfolder via drag and drop

• ✔️ as alice, move multiple files & folders into subfolder via drag and drop

• ✔️ as alice, navigate into a folder, open right sidebar without selection, share current folder with admin

Findings

• ❌ Thumbnail-previews in sidebar for images, textfiles etc are not displayed anymore

No release blocker from my POV, let's ship as-is and publish another (bugfix) release soon

[ScharfViktor]

@ScharfViktor thanks for the testing, the accounts button link in settings is not an release blocker.

Yes, sure. there in nothing that blocks release.