Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement people sharing for resources within a space #6577

Merged
merged 9 commits into from
Mar 18, 2022
Merged

Implement people sharing for resources within a space #6577

merged 9 commits into from
Mar 18, 2022

Conversation

JammingBen
Copy link
Collaborator

@JammingBen JammingBen commented Mar 11, 2022 •
edited
Loading

Description

Resources within a space can now be shared with other people.

Pre-requisites:

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@JammingBen JammingBen self-assigned this Mar 11, 2022
@owncloud owncloud deleted a comment from update-docs bot Mar 11, 2022
@ownclouders
Copy link
Contributor

Results for e2e-tests oC10 https://drone.owncloud.com/owncloud/web/23558/10/1

💥 To see the trace, please open the link in the console ...

npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/23558/tracing/alice-shares-folder-with-file-to-brian-alice-2022-3-11-09-43-48.zip

npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/23558/tracing/alice-shares-folder-with-file-to-brian-brian-2022-3-11-09-43-59.zip

@ownclouders
Copy link
Contributor

Results for oC10XGAPortrait3 https://drone.owncloud.com/owncloud/web/23567/46/1
💥 The acceptance tests pipeline failed. The build has been cancelled.

@ownclouders
Copy link
Contributor

Results for oC10XGAPortrait3 https://drone.owncloud.com/owncloud/web/23617/46/1
💥 The acceptance tests pipeline failed. The build has been cancelled.

@JammingBen JammingBen marked this pull request as ready for review March 14, 2022 12:19
@ownclouders
Copy link
Contributor

Results for oCISSharingInternal2 https://drone.owncloud.com/owncloud/web/23730/60/1
The following scenarios passed on retry:

  • webUISharingInternalUsers/shareWithUsers.feature:180

@ownclouders
Copy link
Contributor

Results for oC10IntegrationApp1 https://drone.owncloud.com/owncloud/web/23730/71/1
The following scenarios passed on retry:

  • webUIPrivateLinks/accessingPrivateLinks.feature:17

@JammingBen JammingBen force-pushed the spaces-members-share-panel branch 2 times, most recently from 040ec37 to 98efd4e Compare March 17, 2022 09:48
@JammingBen JammingBen added the Status:Needs-Review Needs review from a maintainer label Mar 17, 2022
@ownclouders
Copy link
Contributor

Results for oCISSharingPublic1 https://drone.owncloud.com/owncloud/web/23797/67/1
The following scenarios passed on retry:

  • webUISharingPublicBasic/publicLinkPublicActions.feature:44

@ownclouders
Copy link
Contributor

Results for oCISSharingPerm3 https://drone.owncloud.com/owncloud/web/23797/65/1
The following scenarios passed on retry:

  • webUISharingFolderAdvancedPermissionMultipleUsers/sharedFolderWithMultipleUsersAdvancedPermissions.feature:64

@fschade fschade mentioned this pull request Mar 18, 2022
Closed
25 tasks
@ownclouders
Copy link
Contributor

Results for oCISTrashbinUploadMoveJourney https://drone.owncloud.com/owncloud/web/23872/69/1
The following scenarios passed on retry:

  • webUITrashbinDelete/trashbinDelete.feature:105

@ownclouders
Copy link
Contributor

Results for oCISFiles1 https://drone.owncloud.com/owncloud/web/23872/55/1
The following scenarios passed on retry:

  • webUIDeleteFilesFolders/deleteFilesFolders.feature:216

@ownclouders
Copy link
Contributor

Results for oC10IntegrationApp1 https://drone.owncloud.com/owncloud/web/23872/71/1
The following scenarios passed on retry:

  • webUIPrivateLinks/accessingPrivateLinks.feature:9

@delete-merged-branch delete-merged-branch bot deleted the branch master March 18, 2022 11:45
@JammingBen JammingBen changed the base branch from spaces-members-share-panel to master March 18, 2022 11:46
@sonarcloud
Copy link

sonarcloud bot commented Mar 18, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

61.0% 61.0% Coverage
0.0% 0.0% Duplication

kulmann
kulmann approved these changes Mar 18, 2022
View reviewed changes
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@JammingBen JammingBen removed the Status:Needs-Review Needs review from a maintainer label Mar 18, 2022
@kulmann kulmann merged commit f6bf7cd into master Mar 18, 2022
@delete-merged-branch delete-merged-branch bot deleted the sharing-within-spaces branch March 18, 2022 12:31
@kulmann kulmann mentioned this pull request Mar 18, 2022
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulmann kulmann kulmann approved these changes

@pascalwengerter pascalwengerter Awaiting requested review from pascalwengerter

@fschade fschade Awaiting requested review from fschade

Assignees

@JammingBen JammingBen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JammingBen @ownclouders @kulmann