Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Creating group and adding member to group via GraphApi #113

Merged
merged 3 commits into from
Apr 29, 2022
Merged

Creating group and adding member to group via GraphApi #113

merged 3 commits into from
Apr 29, 2022

Conversation

ScharfViktor
Copy link
Contributor

@ScharfViktor ScharfViktor commented Apr 28, 2022 •
edited
Loading

@rhafer rhafer marked this pull request as ready for review April 29, 2022 10:25
@ScharfViktor
Copy link
Contributor Author

I'm waiting green CI
here: owncloud/ocis#3594
and here: owncloud/web#6827

after that it is ready for review

pascalwengerter
pascalwengerter suggested changes Apr 29, 2022
View reviewed changes
Copy link
Contributor

@pascalwengerter pascalwengerter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only super minor thing, after that I'm happy to approve, merge & release!

src/helpers/graphHelper.js Outdated Show resolved Hide resolved
@pascalwengerter pascalwengerter merged commit ad8f4e1 into main Apr 29, 2022
@delete-merged-branch delete-merged-branch bot deleted the createGroupViaGraph branch April 29, 2022 13:26
@saw-jan saw-jan mentioned this pull request Jun 2, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pascalwengerter pascalwengerter pascalwengerter approved these changes

@rhafer rhafer Awaiting requested review from rhafer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ScharfViktor @pascalwengerter