Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[full-ci] Creating user via Graph in e2e tests and UI tests #6827

Merged
merged 4 commits into from
May 2, 2022
Merged

[full-ci] Creating user via Graph in e2e tests and UI tests #6827

merged 4 commits into from
May 2, 2022

Conversation

ScharfViktor
Copy link
Contributor

@ScharfViktor ScharfViktor commented Apr 28, 2022 •
edited by pascalwengerter
Loading

Step 1:

  • e2e tests with ocis use graphApi

Steps 2:

  • UI tests with ocis use graphApi (changes in middleware)

Fixes #6836

@update-docs
Copy link

update-docs bot commented Apr 28, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@ScharfViktor ScharfViktor mentioned this pull request Apr 28, 2022
Merged
@ScharfViktor ScharfViktor changed the title Creating user via Graph in e2e tests and UI tests [full-ci] Creating user via Graph in e2e tests and UI tests Apr 28, 2022
pascalwengerter
pascalwengerter requested changes Apr 28, 2022
View reviewed changes
Copy link
Contributor

@pascalwengerter pascalwengerter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing the middleware version bump in .drone.star

@pascalwengerter
Copy link
Contributor

Missing the middleware version bump in .drone.star

I'm an idiot, we bumped it already yesterday as part of the Uppy-PR. Happy to merge if CI turns green

@ScharfViktor
Copy link
Contributor Author

ScharfViktor commented Apr 28, 2022 •
edited
Loading

Missing the middleware version bump in .drone.star

version was already

web/.drone.star

Line 23 in 9709706

OC_TESTING_MIDDLEWARE = "owncloud/owncloud-test-middleware:1.5.0"

@ownclouders
Copy link
Contributor

ownclouders commented Apr 28, 2022 •
edited
Loading

Results for oCISSharingPublic1 https://drone.owncloud.com/owncloud/web/25068/68/1
The following scenarios passed on retry:

  • webUISharingPublicBasic/publicLinkPublicActions.feature:44
  • webUISharingPublicBasic/publicLinkEdit.feature:57

fschade
fschade requested changes Apr 28, 2022
View reviewed changes
Copy link
Collaborator

@fschade fschade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

found some smaller improvements, nothing crucial.
The me.ts file looks obsolete to me, can we refactor the ma func into user.ts too?

@ScharfViktor
Copy link
Contributor Author

Good idea. I'll move "me" to "user"

@ScharfViktor
Copy link
Contributor Author

e2e tests passed. UI tests as expected failed. I'm doing fix after review and go to step 2

@pascalwengerter pascalwengerter mentioned this pull request Apr 29, 2022
Closed
@ScharfViktor ScharfViktor mentioned this pull request Apr 29, 2022
Merged
@ScharfViktor
Copy link
Contributor Author

CI is green. could you do a review?

before merge: need change - OCIS_COMMITID and OC_TESTING_MIDDLEWARE

@pascalwengerter pascalwengerter mentioned this pull request Apr 29, 2022
Closed
@sonarcloud
Copy link

sonarcloud bot commented May 2, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

pascalwengerter
pascalwengerter approved these changes May 2, 2022
View reviewed changes
Copy link
Contributor

@pascalwengerter pascalwengerter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please use the squash-merge option :) we need to take care of the flaky test next!

fschade
fschade approved these changes May 2, 2022
View reviewed changes
Copy link
Collaborator

@fschade fschade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎸

@ScharfViktor ScharfViktor merged commit 8feefb1 into master May 2, 2022
@delete-merged-branch delete-merged-branch bot deleted the usingGraphApiInTests branch May 2, 2022 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fschade fschade fschade approved these changes

@pascalwengerter pascalwengerter pascalwengerter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

make e2e tests work with GraphAPI of ocis
4 participants
@ScharfViktor @pascalwengerter @ownclouders @fschade