Skip to content

Commit

Permalink
[full-ci] Streamline apps into viewer/editor templates (#9485)
Browse files Browse the repository at this point in the history
---------

Co-authored-by: Dominik Schmidt <dev@dominik-schmidt.de>
Co-authored-by: Jan <j.ackermann91@gmail.com>
  • Loading branch information
3 people authored Sep 13, 2023
1 parent 423d540 commit 1e774b6
Show file tree
Hide file tree
Showing 40 changed files with 948 additions and 968 deletions.
9 changes: 9 additions & 0 deletions changelog/unreleased/enhancement-app-templates
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
Enhancement: Application unification

The existing apps have been refactored and their common functionality has been extracted.
This enables developers to more easily create custom apps, and brings unified behavior like auto-saving, shortcut handling and success/error messages across all file viewer/editor apps.

https://github.com/owncloud/web/issues/9302
https://github.com/owncloud/web/issues/9303
https://github.com/owncloud/web/issues/9617
https://github.com/owncloud/web/pull/9485
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@
"url-search-params-polyfill": "8.1.1",
"vite": "4.3.5",
"vite-plugin-environment": "^1.1.3",
"vue-tsc": "1.6.5",
"vue-tsc": "1.8.10",
"vue3-gettext": "^2.3.3",
"wait-for-expect": "3.0.2"
},
Expand Down
14 changes: 7 additions & 7 deletions packages/design-system/src/components/OcModal/OcModal.vue
Original file line number Diff line number Diff line change
Expand Up @@ -66,8 +66,8 @@

<div class="oc-modal-body-actions oc-flex oc-flex-right">
<oc-button
class="oc-modal-body-actions-cancel"
ref="cancelButton"
class="oc-modal-body-actions-cancel"
:variation="buttonCancelVariation"
:appearance="buttonCancelAppearance"
@click="cancelModalAction"
Expand Down Expand Up @@ -390,12 +390,6 @@ export default defineComponent({
'passwordChallengeCompleted',
'passwordChallengeFailed'
],
data() {
return {
userInputValue: null,
checkboxValue: false
}
},
setup() {
const primaryButton = ref(null)
const secondaryButton = ref(null)
Expand Down Expand Up @@ -431,6 +425,12 @@ export default defineComponent({
cancelButton
}
},
data() {
return {
userInputValue: null,
checkboxValue: false
}
},
computed: {
initialFocusRef(): FocusTargetOrFalse {
if (this.focusTrapInitial) {
Expand Down
Loading

0 comments on commit 1e774b6

Please sign in to comment.