[full-ci] Streamline apps into viewer/editor templates #9485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kulmann
reviewed
Jul 26, 2023
pascalwengerter
force-pushed
the
feature/streamline-apps
branch
from
e000df1 to
c215a0d
Compare
dschmidt
reviewed
Aug 3, 2023
| emits: ['update:currentContent'], | ||
| setup(props) { | ||
| const config = computed(() => { | ||
| // TODO: Remove typecasting once vue-tsc has figured it out |
There was a problem hiding this comment.
Maybe we just need to add one required prop .... .... .... .... ....
dschmidt
reviewed
Aug 3, 2023
dschmidt
reviewed
Aug 3, 2023
dschmidt
force-pushed
the
feature/streamline-apps
branch
from
38dc423 to
1c4ddbe
Compare
dschmidt
reviewed
Aug 3, 2023
dschmidt
reviewed
Aug 3, 2023
dschmidt
force-pushed
the
feature/streamline-apps
branch
from
6f9be4f to
eff2f2b
Compare
dschmidt
reviewed
Aug 4, 2023
dschmidt
reviewed
Aug 4, 2023
AlexAndBear
force-pushed
the
feature/streamline-apps
branch
from
ba2bcd0 to
88109cb
Compare
AlexAndBear
reviewed
Aug 6, 2023
dschmidt
reviewed
Aug 7, 2023
packages/web-pkg/src/components/AppTemplates/AppWrapperRoute.ts
Outdated
Show resolved
Hide resolved
dschmidt
force-pushed
the
feature/streamline-apps
branch
from
76b7029 to
e15d1fb
Compare
dschmidt
reviewed
Sep 12, 2023
dschmidt
approved these changes
Sep 13, 2023
JammingBen
reviewed
Sep 13, 2023
JammingBen
approved these changes
Sep 13, 2023
AlexAndBear
approved these changes
Sep 13, 2023
|
SonarCloud Quality Gate failed.
|
lookacat
reviewed
Sep 13, 2023
ownclouders
pushed a commit
that referenced
this pull request
Sep 13, 2023
--------- Co-authored-by: Dominik Schmidt <dev@dominik-schmidt.de> Co-authored-by: Jan <j.ackermann91@gmail.com>
lookacat
reviewed
Sep 13, 2023
lookacat
reviewed
Sep 13, 2023
AlexAndBear
pushed a commit
that referenced
this pull request
Dec 13, 2023
--------- Co-authored-by: Dominik Schmidt <dev@dominik-schmidt.de> Co-authored-by: Jan <j.ackermann91@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Open Tasks
isDirtyis true: https://web.dev/bfcache/#only-add-beforeunload-listeners-conditionallyopenAppsInTabincloseApp-> we want to keep the tab open for now and just close the apppageTitleand invisible screen reader hint for external (and potentially other) apps