Skip to content

Commit

Permalink
Merge pull request #12054 from owncloud/feat/private-link-error-wording
Browse files Browse the repository at this point in the history
feat: use more generic private link error message
  • Loading branch information
LukasHirt authored Dec 23, 2024
2 parents aa56565 + 8d3a4da commit 2fd35ec
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 16 deletions.
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
Enhancement: Use generic private link error

We've added a more generic error message to the unavailable private links as the previous message was confusing.

https://github.com/owncloud/web/pull/12054
https://github.com/owncloud/web/issues/12009
19 changes: 3 additions & 16 deletions packages/web-runtime/src/pages/resolvePrivateLink.vue
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,6 @@
</div>
<div class="oc-card-body oc-link-resolve-error-message">
<p class="oc-text-xlarge">{{ errorMessage }}</p>
<p
v-if="isUnacceptedShareError"
v-text="$gettext('You can reload this page after you have enabled syncing the share.')"
/>
</div>
</template>
</div>
Expand Down Expand Up @@ -170,18 +166,9 @@ export default defineComponent({
const errorMessage = computed(() => {
if (unref(isUnacceptedShareError)) {
if (!unref(sharedParentResource)) {
return $gettext(
'This file or folder has been shared with you. Enable the sync in "Shares" > "Shared with me" to view it.'
)
} else {
return $gettext(
'This file or folder has been shared with you via "%{parentShareName}". Enable the sync for the share "%{parentShareName}" in "Shares" > "Shared with me" to view it.',
{
parentShareName: unref(sharedParentResource).name
}
)
}
return $gettext(
'The link you are trying to access is invalid or you do not have permission to view the content. Please check the link for any errors or contact the person who shared it for assistance.'
)
}
if (resolvePrivateLinkTask.isError) {
Expand Down

0 comments on commit 2fd35ec

Please sign in to comment.