Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use more generic private link error message #12054

Merged
merged 1 commit into from
Dec 23, 2024
Merged

feat: use more generic private link error message #12054

merged 1 commit into from
Dec 23, 2024

Conversation

LukasHirt
Copy link
Collaborator

Description

Use more generic error message when resolution of private link fails.

Related Issue

Motivation and Context

Prevent confusing errors.

How Has This Been Tested?

  • test environment: chrome
  • test case 1: Open private link of unshared resource with another user

Screenshots (if appropriate):

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests
  • Documentation
  • Maintenance (e.g. dependency updates or tooling)

@LukasHirt LukasHirt added the Category:Enhancement Add new functionality label Dec 23, 2024
@LukasHirt LukasHirt requested a review from saw-jan December 23, 2024 10:40
@LukasHirt LukasHirt self-assigned this Dec 23, 2024
@LukasHirt LukasHirt enabled auto-merge December 23, 2024 10:40
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@LukasHirt LukasHirt merged commit 2fd35ec into master Dec 23, 2024
4 checks passed
@LukasHirt LukasHirt deleted the feat/private-link-error-wording branch December 23, 2024 11:21
@2403905 2403905 mentioned this pull request Jan 10, 2025
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saw-jan saw-jan saw-jan approved these changes

Assignees

@LukasHirt LukasHirt

Labels
Category:Enhancement Add new functionality
Projects
Infinite Scale Team Board
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[QA] misleading error message when private link is not resolvable
2 participants
@LukasHirt @saw-jan