Filter sidebar shares for displayName (#9504)

* Fix #9257 * Move filtering for collaborator displayName in outgoingShares to useShares composable
owncloud · Aug 16, 2023 · a7543e4 · a7543e4
1 parent 50c8945
commit a7543e4
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/changelog/unreleased/bugfix-filter-shares-without-displayname b/changelog/unreleased/bugfix-filter-shares-without-displayname
@@ -0,0 +1,7 @@
+Bugfix: Filter out shares without display name
+
+In rare (legacy) cases, shares can exist without a displayName key, which caused trouble in the sharing sidebar section.
+This has been addressed by filtering out shares without a displayName.
+
+https://github.com/owncloud/web/issues/9257
+https://github.com/owncloud/web/pull/9504
diff --git a/packages/web-app-files/src/composables/shares/useShares.ts b/packages/web-app-files/src/composables/shares/useShares.ts
@@ -5,8 +5,8 @@ import { useStore } from 'web-pkg/src/composables'
 export function useShares() {
   const store = useStore()
   const outgoingLinks: Ref<Share[]> = computed(() => store.getters['Files/outgoingLinks'])
-  const outgoingCollaborators: Ref<Share[]> = computed(
-    () => store.getters['Files/outgoingCollaborators']
+  const outgoingCollaborators: Ref<Share[]> = computed(() =>
+    store.getters['Files/outgoingCollaborators'].filter((s) => s.collaborator.displayName)
   )
   return { outgoingCollaborators, outgoingLinks }
 }